This repository has been archived by the owner on Jul 10, 2020. It is now read-only.
Updates to hero graphic guidelines #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataliafitzgerald
requested review from
jimmynotjim,
Scotchester,
kurzn and
jenn-franklin
|
|
Looks good! Thanks for your work on this. |
|
👍 |
1 similar comment
|
👍 |
jimmynotjim
reviewed
Apr 6, 2017
global-elements/heroes.md
Outdated
|
|
||
| Heroes should be the most prominent thing on the page, and help to establish visual hierarchy of where the page lives within the information architecture. | ||
| <img alt="Image of hero graphic" src="../static/img/hero/hero_use_case.png"/> |
There was a problem hiding this comment.
We've preferred using absolute urls, which would update the source here to {{site.github.urll}}/static/img/hero/hero_use_case.png (We should update all the existing {{site.baseurl}} uses but that's outside the scope of this PR)
global-elements/heroes.md
Outdated
| <div class="content-33"> | ||
|  | ||
| <div class="content-50 content-last"> | ||
| <p>Small screens (600-)</p> |
There was a problem hiding this comment.
Indentation here should be two spaces.
jenn-franklin
approved these changes
Apr 6, 2017
jimmynotjim
approved these changes
Apr 6, 2017
ielerol
suggested changes
Apr 6, 2017
global-elements/heroes.md
Outdated
| <div class="content-33 content-last"></div> | ||
| <h2 id="desktop">Style at desktop size<span class="cf-code-link"><a href="https://github.com/cfpb/capital-framework/blob/master/src/cf-layout/src/cf-layout.less#L618-L620">View code <span class="cf-icon cf-icon-external-link"></span></a></span></h2> | ||
| <h4>When other options are better</h4> | ||
| - When introducing a specific piece of content, like a blog, press release, or other lengthy or detailed content, use the [Text introduction]({{site.baseurl}}/global-elements/text-introduction.html) |
There was a problem hiding this comment.
change the link to point to text-introductions.html
|
@ielerol - I fixed the broken link. Look good to go? |
ielerol
approved these changes
Apr 6, 2017
Scotchester
approved these changes
Apr 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description explaining the high-level reason for the pull request
Additions
Removals
Changes
Testing
Review
Preview this PR without the whitespace changes
Screenshots
Notes
Todos
Checklist