-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apache #5122
Add apache #5122
Conversation
add envvars to confs composed apache-in-docker add ignore entries and fix up module loading scrub factor out ansible dependents and crystalize envvars Update elasticsearch dockerfile to prevent cluster churn
The /data-research/hmda path is now served by Wagtail. This hmda.conf file is no longer part of the regular cf.gov deploy.
The data.json path is now served via a different Apache alias which points to a Django static file.
…ply bring the apache docs into this repo to be handled used in the deploy process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the omission of the maintenance.conf file in the internal repo deliberate?
and remove deprecated newsroom.conf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good. Put up a few questions/comments.
cfgov/apache/conf.d/wsgi.conf
Outdated
ServerName consumerfinance.gov | ||
|
||
WSGIApplicationGroup %{GLOBAL} | ||
WSGIDaemonProcess django processes=${APACHE_PROCESS_COUNT} threads=15 display-name=%{GROUP} python-path=${CFGOV_CURRENT}/venv/lib/python2.7/site-packages:${CFGOV_CURRENT}/venv/lib64/python2.7/site-packages:${CFGOV_CURRENT} home=${CFGOV_CURRENT} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not something we need to change now, just a heads up that python-path
values will need to change once we want to support python2
and python3
services. Also, in a Docker world, you probably won't be using a virtualenv, though I suppose we could if it'd help keep both setups compatible with each other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we got he mod-wsgi-express route, this file won't be relevant in the docker world.
This PR adds our formerly private apache conf files into our open source repo. The benefits are manifold: