Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-10447: Removed references to travis (3.18) #5310

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

craigcomstock
Copy link
Contributor

@craigcomstock craigcomstock commented Aug 25, 2023

  • Removed references to travis

Ticket: ENT-10447
Changelog: none
(cherry picked from commit 16410e0)
@craigcomstock
Copy link
Contributor Author

craigcomstock commented Aug 25, 2023

looks like on 3.18.x and not master, passopenfile_test fails as it did in travis on macos?

2023-08-25T16:29:47.8104520Z   CC       passopenfile_test.o
2023-08-25T16:29:48.0934150Z passopenfile_test.c:188:23: warning: 'tempnam' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of tempnam(3), it is highly recommended that you use mkstemp(3) instead. [-Wdeprecated-declarations]
2023-08-25T16:29:48.1033680Z         char *using = tempnam("/tmp", "cfpof");
2023-08-25T16:29:48.1134120Z                       ^
2023-08-25T16:29:48.1236480Z /Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:312:1: note: 'tempnam' has been explicitly marked deprecated here
2023-08-25T16:29:48.1337510Z __deprecated_msg("This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of tempnam(3), it is highly recommended that you use mkstemp(3) instead.")
2023-08-25T16:29:48.1436900Z ^
2023-08-25T16:29:48.1539080Z /Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:215:48: note: expanded from macro '__deprecated_msg'
2023-08-25T16:29:48.1627180Z         #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
2023-08-25T16:29:48.1696850Z                                                       ^
2023-08-25T16:29:48.1764770Z 1 warning generated.
2023-08-25T16:29:48.1969650Z   CCLD     passopenfile_test

and the failure:

ERROR: passopenfile_test.c:1347 Failure!
test_listen_outlive: Starting test
    test_listen_outlive
test_listen_outlive: Starting test
   error: Received wrong-sized lament (0 != 27): 
test_listen_outlive: Test failed.

master is fine, locally I get a different failure

test_connect_outlive: Starting test
  notice: Killed previous child process (PID 82700)
   error: Timed out select() for descriptor 5
chat && "can use received fds after sender exits"
ERROR: passopenfile_test.c:1310 Failure!
test_connect_outlive: Test failed.

@craigcomstock
Copy link
Contributor Author

I re-disabled passopenfile_test, I guess it doesn't work well, sometimes? We'll see how it goes in master.

@craigcomstock craigcomstock merged commit 4022a20 into cfengine:3.18.x Aug 26, 2023
6 checks passed
@craigcomstock craigcomstock deleted the ENT-10447/3.18 branch August 26, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant