Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update to PR template community file #491

Merged

Conversation

sadielbartholomew
Copy link
Member

See issue #XXX for discussion of these changes.
See #489 (comment) for the context behind the core update, which is to state to be explicit that there are two places where names should be updated in the cf-conventions.adoc document, preventing confusion in future that led to separate PRs being required to add names again.

Since this is an infrastructure tweak, the release checklist is not applicable so I have quoted it to effectively comment it out.

@larsbarring I have assigned you as reviewer since you are quite active on this repo of late, but feel free to re-assign should you wish. I don't think the change is controversial but will need someone to approve it regardless to confirm it's OK. Thanks.

Release checklist

  • [ ] Authors updated in cf-conventions.adoc?
  • Next version in cf-conventions.adoc up to date? Versioning inspired by SemVer.
  • history.adoc up to date?
  • Conformance document up-to-date?
  • [ ]

For maintainers

After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then, main always is a draft for the next version.

@sadielbartholomew sadielbartholomew added the GitHub Improvement to how we use GitHub for this repository label Nov 28, 2023
@sadielbartholomew sadielbartholomew self-assigned this Nov 28, 2023
@larsbarring larsbarring added this to the 1.11 milestone Nov 28, 2023
@sadielbartholomew
Copy link
Member Author

Thanks for the prompt review, @larsbarring. Can I now merge this?

@larsbarring
Copy link
Contributor

Yes, please do /Lars

@sadielbartholomew sadielbartholomew merged commit 34be44d into cf-convention:main Nov 28, 2023
4 checks passed
@sadielbartholomew sadielbartholomew deleted the update-pr-template branch November 28, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub Improvement to how we use GitHub for this repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants