Add conformance tests #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
approved
inteon
force-pushed
the
add_conformance_tests
branch
from
7c6d345
to
9a3da83
Compare
inteon
force-pushed
the
add_conformance_tests
branch
from
9a3da83
to
eac6418
Compare
Signed-off-by: Tim Ramlot <[email protected]>
…R and CSR tests Signed-off-by: Tim Ramlot <[email protected]>
Signed-off-by: Tim Ramlot <[email protected]>
Signed-off-by: Tim Ramlot <[email protected]>
Signed-off-by: Tim Ramlot <[email protected]>
Signed-off-by: Tim Ramlot <[email protected]>
Signed-off-by: Tim Ramlot <[email protected]>
Signed-off-by: Tim Ramlot <[email protected]>
inteon
force-pushed
the
add_conformance_tests
branch
2 times, most recently
from
1c16b6f
to
e98ed4e
Compare
Signed-off-by: Tim Ramlot <[email protected]>
inteon
force-pushed
the
add_conformance_tests
branch
from
e98ed4e
to
a9c55ba
Compare
Signed-off-by: Tim Ramlot <[email protected]>
Signed-off-by: Tim Ramlot <[email protected]>
inteon
force-pushed
the
add_conformance_tests
branch
from
5a8b9ee
to
44da812
Compare
Signed-off-by: Tim Ramlot <[email protected]>
Signed-off-by: Tim Ramlot <[email protected]>
inteon
commented
Jun 30, 2023
| @@ -46,7 +46,7 @@ func (vi *SimpleIssuer) GetStatus() *v1alpha1.IssuerStatus { | |||
| } | |||
|
|
|||
| func (vi *SimpleIssuer) GetIssuerTypeIdentifier() string { | |||
| return "simpleissuers.issuer.cert-manager.io" | |||
| return "simpleissuers.testing.cert-manager.io" | |||
There was a problem hiding this comment.
We were using "simpleissuers.issuer.cert-manager.io", which does not match our group name.
jetstack-bot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a conformance tests module that is based on the cert-manager conformance tests.
This module is compiled into a ginkgo binary and can be run on any cluster setup.
The tests and the framework have been cleaned up and updated to be configurable through flags only.
These conformance tests are stand-alone and we might move them to cert-manager/cert-manager at some point.
Ultimately, this module just generates a binary which can be easily used to conformance test your issuer.