[Helm Chart] Add env, configmap, secret and volumes support #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @inteon, let me know if you would like me to make a separate Issue to correspond to this PR and/or if you need anything else from me. |
cert-manager-prow
bot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the use case of using
google-cas-issueroutside of GKE but want to lean on GCP's Workload Identity instead of static Service Account credentials.We can achieve this by using a ConfigMap/Secret mounting the Workload Identity Pool credential configuration JSON and referencing it via the
GOOGLE_APPLICATION_CREDENTIALSenvironment variable.This PR enables this with the generic solution of supporting arbitrary
env, ConfigMap, Secret andvolumes/volumeMountssupport.