New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

power_spectrum2 #43

Merged

arthur-lin1027 merged 24 commits into main from power_spectrum2

Dec 13, 2024

Contributor

SeonwooH commented Jul 18, 2024

added a few more updates for power_spectrum2 function

황선우 added 2 commits

July 11, 2024 00:48


          updated power_spectrum function

231c018


          updates for power_spectrum function

907587e

SeonwooH requested a review from arthur-lin1027

July 18, 2024 14:06

arthur-lin1027 requested changes

View reviewed changes

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

arthur-lin1027 requested changes

View reviewed changes

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

황선우 added 2 commits

July 25, 2024 02:39


          final update of power_spectrum function

40e3a2c


          last update

e517f37

arthur-lin1027 requested changes

View reviewed changes

Collaborator

arthur-lin1027 left a comment

add skmatter to the tests/requirements.txt file

SeonwooH requested a review from rosecers

August 20, 2024 16:50

rosecers reviewed

View reviewed changes

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

rosecers reviewed

View reviewed changes

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

rosecers reviewed

View reviewed changes

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

rosecers reviewed

View reviewed changes

notebooks/anisotropic_representations.ipynb Outdated Show resolved Hide resolved

rosecers reviewed

View reviewed changes

setup.py Outdated Show resolved Hide resolved

황선우 added 6 commits

September 6, 2024 00:06


          added docstrings and modified the function

8ef7696


          updated power_spectrum function

bcc4605


          updates for power_spectrum function

8425aef


          final update of power_spectrum function

24c06b2


          last update

407febf


          added docstrings and modified the function

20fb1f1

arthur-lin1027 force-pushed the power_spectrum2 branch from 8ef7696 to 20fb1f1 Compare

September 10, 2024 18:49

arthur-lin1027 and others added 7 commits

September 10, 2024 13:53


          added skmatter

2260b7d


          Added a few comments

b8d7e81


          added a few comments

bf8437e


          resolved merge conflicts

2e9ec6d


          adding the invarience of powerspectrum notebook

f522793


          linter

42459e1


          Update tests.yml removed python 3.8

53dacdc

rascaline requires python ver >=3.9

arthur-lin1027 previously requested changes

View reviewed changes

Collaborator

arthur-lin1027 left a comment

Please checkout these comments!

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved


          few changes after feedback

159a5f5

arthur-lin1027 added 4 commits

October 3, 2024 19:54


          undo linting changes in notebooks

a8603c8


          one more reset of linting changes in notebooks -- we want to keep thi…

19322aa

…s separate


          Slightly edited and organized Invarainces example

cfeb979


          Merge branch 'main' into power_spectrum2

734ca1e

Puts some versioning changes that are in main into this branch so tests can run correctly.

rosecers reviewed

View reviewed changes

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

anisoap/representations/ellipsoidal_density_projection.py Outdated Show resolved Hide resolved

rosecers added 2 commits

December 12, 2024 16:05


          Apply suggestions from code review

e521e34


          Lint

2aba961

rosecers dismissed arthur-lin1027’s stale review

December 12, 2024 22:12

Discussion with Arthur

rosecers approved these changes

View reviewed changes

arthur-lin1027 merged commit 1a8ce65 into main

3 checks passed

arthur-lin1027 deleted the power_spectrum2 branch

December 13, 2024 21:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet