Adding gaussian normalization #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosecers
force-pushed
the
normalized_mvg
branch
2 times, most recently
from
19e1c52 to
b115fbe
Compare
rosecers
force-pushed
the
normalized_mvg
branch
2 times, most recently
from
1674d1b to
5a02940
Compare
arthur-lin1027
force-pushed
the
normalized_mvg
branch
from
b7ef013 to
20b1b37
Compare
arthur-lin1027
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
i'm ok with merging this in now for the sake of not leaving this branch dangling for way too long, although this will likely need further iteration.
In the future I will make various tests to ensure gaussian normalization and to test other pieces of the code as well (e.g. that Jigyasa's tensor products do what they're supposed to)
|
@arthur-lin1027 should we close? |
rosecers
commented
Apr 30, 2024
arthur-lin1027
force-pushed
the
normalized_mvg
branch
from
05457d6 to
7b0656f
Compare
The integral of a monomial * a atom-centered gaussian does not change the gaussian in the same way that a GTO does. Hence the c term is 0.
cbefan
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not quite sure why it needs the volume, but that's apparently the thing.