This repository has been archived by the owner on May 22, 2024. It is now read-only.
Upgrade to support NPMv9 #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdadn
commented
Aug 21, 2023
| @@ -1 +1,2 @@ | |||
| package-lock=false | |||
| legacy-peer-deps=true | |||
There was a problem hiding this comment.
NPMv7+ automatically installs peer dependencies. However, Terra currently has in peer dependency versions which can cause install failures. This flag when set will utilize the legacy behavior of not installing peer dependencies in v6. This will be removed in a future PR when the conflicts are resolved.
sycombs
approved these changes
Aug 21, 2023
.github/actions/setup/action.yml
Outdated
Comment on lines
15
to
16
| run: node -v | ||
| run: npm -v |
There was a problem hiding this comment.
@sdadn Try this
Suggested change
| run: node -v | |
| run: npm -v | |
| run: | | |
| node -v | |
| npm -v |
nikhitasharma
approved these changes
Aug 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the repo set up to support NPMv9 so to help upgrade the infrastructure and be up to date with our tech stack.
Since Node 14 ships with NPMv6, the cicd was updated to utilize NPMv9.
Testing
This change was tested using:
This was tested by successfully running
npm installand building the project with both NPM versions (6 & 9).Reviews
In addition to engineering reviews, this PR needs:
Additional Details
Thank you for contributing to Terra.
@cerner/terra