Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

[terra-clinical-label-value-view] Fix margin for dl elements #904

Merged
merged 4 commits into from
Aug 29, 2023
Merged

[terra-clinical-label-value-view] Fix margin for dl elements #904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f61110
[terra-clinical-label-value-view] Fix padding for dl elements
smason0 Aug 17, 2023
8343e03
WDIO screens
smason0 Aug 17, 2023
410a33d
changelog
smason0 Aug 17, 2023
318b13d
Change from margin-block to margin for browser compatibility
smason0 Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/terra-clinical-label-value-view/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

* Fixed
* Removed extra top and bottom margins from LabelValueView description list.

## 3.31.0 - (August 2, 2023)

* Changed
Expand Down
2 changes: 2 additions & 0 deletions packages/terra-clinical-label-value-view/src/LabelValueView.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
:local {
.label-value-view {
border: 0;
margin-bottom: 0;
margin-top: 0;
padding: 0;
word-break: break-word;
word-wrap: break-word;
Expand Down
5 changes: 5 additions & 0 deletions ...clinical-label-value-view/src/terra-dev-site/doc/example/LabelValueViewTextTermAndDef.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ const LabelValueViewText = () => (
#dl-wrapper > dd {
margin-bottom: 14px;
}

#dl-wrapper {
margin-bottom: 0;
margin-top: 0;
}
Comment on lines +12 to +15
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to add a style on the wrapper element if we are updating our sass file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being applied to the <dl> element on line 19 for this specific example and not the one in LableValueView that had its sass file updated. This change is maybe not needed, as it is just an example, but I added it to be consistent in removing these default margins whenever we use a definition list.

`}
</style>
<h4 id="topicText">Vitals</h4>
Expand Down
5 changes: 5 additions & 0 deletions ...e-view/src/terra-dev-site/test/clinical-label-value-view/TextValueLabelValueView.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ const examples = () => (
#dl-wrapper > dd {
margin-bottom: 14px;
}

#dl-wrapper {
margin-bottom: 0;
margin-top: 0;
}
`}
</style>
<h3>LabelValueView returned as a term and a definition (isChildOfDescriptionList=&apos;true&apos;):</h3>
Expand Down
Binary file modified ...e/clinical-lowlight-theme/en/chrome_medium/label-value-view-spec/text_value.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...rence/terra-default-theme/en/chrome_medium/label-value-view-spec/text_value.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading