refactor: upgrade to datafusion 43 #600
Open
+214
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
force-pushed
the
feat/flight-sql-prepared-statements
branch
from
716ef09
to
74e55a0
Compare
dav1do
approved these changes
Nov 19, 2024
Cargo.toml
Outdated
|
|
||
| [patch."https://github.com/datafusion-contrib/datafusion-federation.git"] | ||
| # Can remove once https://github.com/datafusion-contrib/datafusion-federation/pull/81 merges | ||
| datafusion-flight-sql-server = { path = "../datafusion-federation/datafusion-flight-sql-server" } |
There was a problem hiding this comment.
Looks like this should be your repo for now: datafusion-flight-sql-server = { git = "https://github.com/nathanielc/datafusion-federation.git", branch = "feat/put-prepared" }
There was a problem hiding this comment.
Yeah, I should point at my branch... However reviews on that repo are pretty fast so I am hoping that it gets reviewed before this is ready to merge so that I can just point to main instead of my branch. If not I'll update here.
| @@ -22,13 +22,13 @@ pub async fn run( | |||
| /// Constructs a new server and can be started. | |||
| pub fn new_server(ctx: SessionContext) -> anyhow::Result<Router> { | |||
| let svc = FlightServiceServer::new( | |||
| FlightSqlService::new(ctx.state()).with_sql_options(Some( | |||
| FlightSqlService::new(ctx.state()).with_sql_options( | |||
| @@ -178,7 +180,7 @@ impl TableProvider for CacheTable { | |||
| &self, | |||
| _state: &dyn Session, | |||
| input: Arc<dyn ExecutionPlan>, | |||
| overwrite: bool, | |||
| insert_op: InsertOp, | |||
nathanielc
had a problem deploying
to
dev-qa-2024
GitHub Actions
Failure
nathanielc
temporarily deployed
to
dev-qa-2024
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #599 See for the real work datafusion-contrib/datafusion-federation#81