Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lit Protocol PKP Wallet Support #140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DustilDawn
Copy link

@DustilDawn DustilDawn commented Jan 18, 2023

Hey there, so I've been working on Lit Protocol during this hackathon and made it work with PKP! This will be a great shared account feature for the ecosystem!

https://github.com/DustilDawn/orbis-sdk/blob/de27fe2a4d2a312c4211c90bfda87c423fe2c174/index.js#L6

PKP Wallet Support - #[Issue]

Description

Include a summary of the change and which issue it addresses in the title of the PR.

Include relevant motivation, context, brief description and impact of the change(s). List follow-up tasks here.

How Has This Been Tested?

Describe the tests that you ran to verify your changes. Provide instructions for reproduction.

Definition of Done

Before submitting this PR, please make sure:

  • The work addresses the description and outcomes in the issue
  • I have added relevant tests for new or updated functionality
  • My code follows conventions, is well commented, and easy to understand
  • My code builds and tests pass without any errors or warnings
  • I have tagged the relevant reviewers
  • I have updated the READMEs of affected packages
  • I have made corresponding changes to the documentation
  • The changes have been communicated to interested parties

References:

Please list relevant documentation (e.g. tech specs, articles, related work etc.) relevant to this change, and note if the documentation has been updated.

Hey there, so I've been working on Lit Protocol during this hackathon and made it work with PKP! This will be a great shared account feature for the ecosystem!

https://github.com/DustilDawn/orbis-sdk/blob/de27fe2a4d2a312c4211c90bfda87c423fe2c174/index.js#L6
Copy link
Member

@oed oed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this would be needed. The safeSend function should already take care of using sendAsync: https://github.com/ceramicnetwork/js-did/blob/main/packages/pkh-ethereum/src/utils.ts#L17

If there is an issue, then the safeSend function should be modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants