Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: FeedAggregationStore #3191

Merged
merged 5 commits into from
Apr 3, 2024
Merged

feat: FeedAggregationStore #3191

merged 5 commits into from
Apr 3, 2024

Conversation

ukstv
Copy link
Contributor

@ukstv ukstv commented Mar 21, 2024

No description provided.

@linear Linear
Copy link

linear bot commented Mar 21, 2024

WS2-3115 Make a FeedStore LevelDB

@ukstv ukstv force-pushed the feature/ws2-3115-make-a-feedstore-leveldb branch from 232d9c4 to 62f68af Compare March 21, 2024 16:02
JulissaDantes
JulissaDantes reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@JulissaDantes JulissaDantes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great, just left a little question to understand better.

packages/core/src/__tests__/ceramic-api.test.ts Outdated Show resolved Hide resolved
Base automatically changed from su/level-2 to develop March 27, 2024 14:54
@ukstv ukstv force-pushed the feature/ws2-3115-make-a-feedstore-leveldb branch from 013b012 to ca88c7c Compare March 28, 2024 14:59
JulissaDantes
JulissaDantes approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@JulissaDantes JulissaDantes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I dont think the CI error is related to your change because when working on a different task I randomly got that same error too.

@JulissaDantes
Copy link
Contributor

Can you rebase this to solve the CI issues and merge this PR? @ukstv

@ukstv ukstv force-pushed the feature/ws2-3115-make-a-feedstore-leveldb branch 2 times, most recently from b2ce6aa to 8e5c83f Compare April 2, 2024 17:19
@ukstv ukstv force-pushed the feature/ws2-3115-make-a-feedstore-leveldb branch from 8e5c83f to 464c839 Compare April 3, 2024 10:44
@ukstv ukstv merged commit db38970 into develop Apr 3, 2024
8 checks passed
@ukstv ukstv deleted the feature/ws2-3115-make-a-feedstore-leveldb branch April 3, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulissaDantes JulissaDantes JulissaDantes approved these changes

@stephhuynh18 stephhuynh18 Awaiting requested review from stephhuynh18

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ukstv @JulissaDantes