feat: add sepolia to allow chain for dev-unstable #3187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbrody
requested changes
Mar 15, 2024
stbrody
reviewed
Mar 15, 2024
| @@ -4,13 +4,15 @@ export type SupportedNetwork = | |||
| | 'eip155:5' // goerli | |||
| | 'eip155:100' // gnosis | |||
| | 'eip155:1337' // ganache | |||
| | 'eip155:11155111' // sepolia | |||
|
|
|||
| export const BLOCK_THRESHHOLDS: Record<SupportedNetwork, number> = { | |||
There was a problem hiding this comment.
looks like this constant isn't actually used anywhere, let's just delete it.
There was a problem hiding this comment.
note there's a similar constant in ethereum-anchor-validator.ts that is used however, and still need to be updated.
There was a problem hiding this comment.
The type is used on line 9 above, no?
Can that be removed too?
There was a problem hiding this comment.
sorry, this comment is on line 9, so I'm not sure what you're referring to. I'm saying the BLOCK_THRESHHOLDS constant in this file is defined but never used.
Also there's a BLOCK_THRESHHOLDS constant in ethereum-anchor-validator.ts that is used and I think still needs to be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Sepolia chain id to the allowed list for dev-unstable.