-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable anchoring on recon mode #3185
Merged
JulissaDantes
merged 31 commits into
develop
from
feature/ws2-3129-enable-anchoring-as-part-of-the-ceramic_recon_mode
Apr 1, 2024
Merged
Changes from 11 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
f8c8bd1
chore: enable anchoring on recon mode
JulissaDantes 3b6a068
chore: make tests support enabled recon
JulissaDantes e21f329
chore: expose recon in package index
JulissaDantes 8a74337
fix: update tests
JulissaDantes 674d69d
chore: skip tests using tile docs
JulissaDantes b65ad46
chore: remove console log
JulissaDantes 692c730
chore: restore skip describe
JulissaDantes e6e3069
chore: remove unused library
JulissaDantes 517ac32
refactor: model instance document test
JulissaDantes bc68b0a
chore: refactor beforeAll hook
JulissaDantes aa7e94a
fix: test delay
JulissaDantes 60696ad
Merge branch 'develop' into feature/ws2-3129-enable-anchoring-as-part…
JulissaDantes b9a4fdb
chore: update tests
JulissaDantes 6ea0c7f
chore: run lint
JulissaDantes 0d28018
chore: update tests
JulissaDantes c525ff9
chore: update tests
JulissaDantes 31eba9e
chore: remove .only
JulissaDantes c058d42
feat: add test delay
JulissaDantes df32401
fix: post merge fix
JulissaDantes 82f3c32
fix: add delay to test
JulissaDantes e9872ae
fix: update tests
JulissaDantes f8fa7e9
Merge branch 'develop' into feature/ws2-3129-enable-anchoring-as-part…
JulissaDantes cdd99b1
fix: add needed delay time
JulissaDantes 4561c7f
chore: run lint
JulissaDantes c07bc3a
feat: update default creation values
JulissaDantes cda3492
Merge branch 'develop' into feature/ws2-3129-enable-anchoring-as-part…
JulissaDantes 73108bb
refactor: replace delays for waitFor
JulissaDantes 43cca09
refactor: change test
JulissaDantes b250250
fix: update test
JulissaDantes 14d58fd
refactor: test hooks
JulissaDantes 5f29187
fix: undo anchor added delay
JulissaDantes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ukstv This is how I solved it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the issue you were seeing? This change really shouldn't be necessary. This sleep isn't actually making the test wait for anything to happen, it's just so that the Node event loop has an interrupt point so other jobs can get scheduled, otherwise the generator can just emit events forever without the task to process those events ever running. But increasing the duration of the sleep should have no affect on the rest of the system or the test, unless I really misunderstood something when I wrote this test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this test failure was the issue: https://app.circleci.com/pipelines/github/ceramicnetwork/js-ceramic/13094/workflows/f7e8914c-f718-40e3-bfd6-4ee07174026c/jobs/18766
Put together a PR that I believe should fix the race condition in the test: #3192
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that was the issue, thanks for the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this change be reverted now that #3192 is in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping