Refactor MakeTLSConfig and support mTLS on server #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tie
force-pushed
the
mutual-tls
branch
2 times, most recently
from
7b88e8e to
bf9ba76
Compare
|
Many thanks! Could you please fix lint warnings? Otherwise, seems great – I'll take a closer look one more time soon. One question, to understand the impact - in your use case, for which Centrifugo component you want to use mTLS? |
This change is a preparation for refactoring MakeTLSConfig and adds tests to ensure that we keep the current behavior. To make testing easier, we pass os.ReadFile as an argument and use fstest.MapFS.ReadFile in tests. In particular, this also means avoiding tls.LoadX509KeyPair.
This change refactors TLS configuration builder and improves error messages to contain configuration key that caused an error.
This change adds support for enabling mutual TLS authentication for Centrifugo servers.
|
@FZambia, fixed linter warnings.
We are using Centrifugo behind a load balancer and with mTLS to secure traffic between load balancers and Centrifugo instances. Currently, we are using Ghostunnel to proxy TLS connections to Centrifugo running on localhost, however, we find this less reliable than exposing mTLS-authenticated Centrifugo directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds tests for and refactors
tools.MakeTLSConfigand then adds support for enabling mutual TLS authentication for Centrifugo servers by settingClientCAsandClientAuthintls.Config.