-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emergency migration to jwt-go v4 #107
Conversation
To fix jwt parsing problem (issue in jwt-go [centrifugal#348](dgrijalva/jwt-go#348)) emergency migrated to v4.
@GSokol hello! Could you explain why this is an Since this pull request introduces migration to preview version of JWT library it requires a careful consideration on what is the best way to deal with this problem. |
@FZambia, hello! Sorry for panic! In my case tokens are issued by third party auth service. I used Microsoft Authentication Server, then Ory Hydra. Yes, maybe, that’s not generally emergency situation, but standard discomplaints seems confusing. |
Will try to look at jwt-go alternatives. For example https://github.com/cristalhq/jwt seems very clean and performs a bit better for decoding. Btw are you using Centrifugo server or this library directly? |
Yes, I'm using Centrifugo server. Why don't you want to use https://github.com/square/go-jose implementation? |
Just a personal preference I suppose, |
jwt implementation a lot, for example another https://github.com/pascaldekloe/jwt |
@FZambia thanks ( Maybe library isn't so popular, but it does what it should. Suggestions are pretty welcome. |
Closing in favour of #109 which was just merged. @GSokol thanks for report, I think your case must be solved with next server release. If you want - you can post an example token in your format and I'll double check it is being decoded well now (I added a couple of tests for tokens with |
To fix jwt parsing problem (issue in jwt-go #348) emergency migrated to v4.