Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sun-mgmt): the default plink command was not applied #5369

Conversation

omercier
Copy link
Contributor

Description

It made tests fail on connectors worflow.

Refs: CTOR-1197

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched.
Provide clear instructions so that it can be correctly tested.
Mention the automated tests included in this FOR (what they test like mode/option combinations).

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
    • Data used for automated tests are anonymized.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences end with a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

It made tests fail on connectors worflow.

Refs: CTOR-1197
@omercier omercier requested a review from a team as a code owner December 27, 2024 14:04
@omercier omercier requested a review from Evan-Adam December 27, 2024 14:04
itoussies
itoussies previously approved these changes Dec 27, 2024
@omercier omercier requested a review from sdepassio December 27, 2024 14:49
sdepassio
sdepassio previously approved these changes Dec 27, 2024
@omercier omercier dismissed stale reviews from sdepassio and itoussies via 595cad0 December 27, 2024 15:46
@omercier omercier requested a review from a team as a code owner December 27, 2024 15:46
@omercier omercier merged commit b8927e6 into develop Dec 27, 2024
27 checks passed
@omercier omercier deleted the CTOR-1197-Version-2023XXXX-of-plugin-not-available-for-Debian-12 branch December 27, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants