fix(cisco-standard): mode configuration wrong calculation #5282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omercier
reviewed
Dec 17, 2024
| closure_custom_perfdata => $self->can('custom_status_perfdata'), | ||
| closure_custom_threshold_check => \&catalog_status_threshold, | ||
| perfdatas => [ | ||
| { template => '%s', min => 0 } |
There was a problem hiding this comment.
Suggested change
| { template => '%s', min => 0 } | |
| { template => '%s', min => 0, unit => 's' } |
| You can use the following variables: %{running_last_changed}, %{running_last_saved}, %{startup_last_changed} | ||
|
|
||
| =item B<--critical-status> | ||
| =item B<--warning-*> B<--critical-*> |
There was a problem hiding this comment.
Suggested change
| =item B<--warning-*> B<--critical-*> | |
| =item B<--warning-config-running-ahead> | |
| Thresholds. | |
| =item B<--critical-config-running-ahead> |
| Define the conditions to match for the status to be CRITICAL (default: '%{running_last_changed} > %{running_last_saved}'). | ||
| You can use the following variables: %{running_last_changed}, %{running_last_saved}, %{startup_last_changed} | ||
| Thresholds. | ||
| Can be: 'config-running-ahead'. |
There was a problem hiding this comment.
Suggested change
| Can be: 'config-running-ahead'. |
Comment on lines
+91
to
+93
| my $ccmHistoryRunningLastChanged = $ctime - $uptime + ($results->{$oid_ccmHistoryRunningLastChanged} / 100); | ||
| my $ccmHistoryRunningLastSaved = $ctime - $uptime + ($results->{$oid_ccmHistoryRunningLastSaved} / 100); | ||
| my $ccmHistoryStartupLastChanged = $ctime - $uptime + ($results->{$oid_ccmHistoryStartupLastChanged} / 100); |
There was a problem hiding this comment.
Suggested change
| my $ccmHistoryRunningLastChanged = $ctime - $uptime + ($results->{$oid_ccmHistoryRunningLastChanged} / 100); | |
| my $ccmHistoryRunningLastSaved = $ctime - $uptime + ($results->{$oid_ccmHistoryRunningLastSaved} / 100); | |
| my $ccmHistoryStartupLastChanged = $ctime - $uptime + ($results->{$oid_ccmHistoryStartupLastChanged} / 100); | |
| my $start_time = $ctime - $uptime; | |
| my $ccmHistoryRunningLastChanged = $start_time + ($results->{$oid_ccmHistoryRunningLastChanged} / 100); | |
| my $ccmHistoryRunningLastSaved = $start_time + ($results->{$oid_ccmHistoryRunningLastSaved} / 100); | |
| my $ccmHistoryStartupLastChanged = $start_time + ($results->{$oid_ccmHistoryStartupLastChanged} / 100); |
Comment on lines
+111
to
+112
| my $runningUnchangedDuration = time() - $ccmHistoryRunningLastChanged; | ||
| my $startupUnchangedDuration = time() - $ccmHistoryStartupLastChanged; |
There was a problem hiding this comment.
Suggested change
| my $runningUnchangedDuration = time() - $ccmHistoryRunningLastChanged; | |
| my $startupUnchangedDuration = time() - $ccmHistoryStartupLastChanged; | |
| my $runningUnchangedDuration = $ctime - $ccmHistoryRunningLastChanged; | |
| my $startupUnchangedDuration = $ctime - $ccmHistoryStartupLastChanged; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community contributors
Description
It fixed following issue: #4908
CTOR-1081
Type of change
How this pull request can be tested ?
You can test it with following snmpwalk:
Checklist