Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MON-22331] [Plugins] Mode sql-string not working anymore #4746

Conversation

lucie-dubrunfaut
Copy link
Contributor

Description

Mode sql-string not working anymore because of unescaped literal "{" characters in regular expression patterns are no longer permissible in perl version > 5.26
https://perldoc.perl.org/5.26.0/perldelta

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Result was :

perl centreon_plugins.pl --plugin=database::mysql::plugin --mode='sql-string'
Unescaped left brace in regex is passed through in regex; marked by <-- HERE in m/\$self->{ <-- HERE result_values}->{(value_field|key_field)}/ at /home/ldubrunfaut/centreon-plugins/src/centreon/common/protocols/sql/mode/sqlstring.pm line 99.
Unescaped left brace in regex is passed through in regex; marked by <-- HERE in m/\$self->{result_values}->{ <-- HERE (value_field|key_field)}/ at /home/ldubrunfaut/centreon-plugins/src/centreon/common/protocols/sql/mode/sqlstring.pm line 99.
Unescaped left brace in regex is passed through in regex; marked by <-- HERE in m/\%{ <-- HERE (value_field|key_field)}/ at /home/ldubrunfaut/centreon-plugins/src/centreon/common/protocols/sql/mode/sqlstring.pm line 101.
UNKNOWN: Need to specify data_source arguments. 

Result now :

perl centreon_plugins.pl --plugin=database::mysql::plugin --mode='sql-string'
UNKNOWN: Need to specify data_source arguments. 

@lucie-dubrunfaut lucie-dubrunfaut marked this pull request as ready for review November 21, 2023 09:33
@lucie-dubrunfaut lucie-dubrunfaut requested review from a team and itoussies November 21, 2023 09:33
itoussies
itoussies previously approved these changes Nov 21, 2023
@lucie-dubrunfaut lucie-dubrunfaut requested review from a team and sc979 November 21, 2023 14:28
sc979
sc979 previously approved these changes Nov 21, 2023
@sc979 sc979 requested a review from itoussies November 21, 2023 15:25
itoussies
itoussies previously approved these changes Nov 21, 2023
Lucie Dubrunfaut added 2 commits November 21, 2023 17:04
Merge branch 'MON-22331-plugins-centreon-plugin-applications-databases-mysql-centreon-plugin-applications-databases-oracle-and-centreon-plugin-applications-databases-mssql-mode-sql-string-not-working-anymore' of github.com:centreon/centreon-plugins into MON-22331-plugins-centreon-plugin-applications-databases-mysql-centreon-plugin-applications-databases-oracle-and-centreon-plugin-applications-databases-mssql-mode-sql-string-not-working-anymore
@lucie-dubrunfaut lucie-dubrunfaut dismissed stale reviews from itoussies and sc979 via cf4e0ee November 21, 2023 16:06
@lucie-dubrunfaut lucie-dubrunfaut marked this pull request as ready for review November 22, 2023 10:40
@lucie-dubrunfaut lucie-dubrunfaut requested a review from a team November 22, 2023 10:41
s-duret
s-duret previously approved these changes Nov 22, 2023
itoussies
itoussies previously approved these changes Nov 22, 2023
sc979
sc979 previously approved these changes Nov 22, 2023
@lucie-dubrunfaut lucie-dubrunfaut requested a review from a team November 28, 2023 15:37
@omercier omercier requested a review from sdepassio December 19, 2023 13:43
sdepassio
sdepassio previously approved these changes Dec 28, 2023
…tions-databases-mysql-centreon-plugin-applications-databases-oracle-and-centreon-plugin-applications-databases-mssql-mode-sql-string-not-working-anymore
@lucie-dubrunfaut lucie-dubrunfaut merged commit c5e5701 into develop Jan 4, 2024
11 checks passed
@lucie-dubrunfaut lucie-dubrunfaut deleted the MON-22331-plugins-centreon-plugin-applications-databases-mysql-centreon-plugin-applications-databases-oracle-and-centreon-plugin-applications-databases-mssql-mode-sql-string-not-working-anymore branch January 4, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants