Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-21973-date-problem-on-storage-ibm-storwize-ssh-plugin-eventlog #4676

Conversation

y-kacher
Copy link
Contributor

fix: Converting from epoch to normal date, format was not valid for localtime()

Description

PLEASE MAKE SURE THAT THE BRANCH PR INCLUDES JIRA TICKET ID (for centreon-internal)

Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:

  • QA Team (Quality Assurance) with tests.
  • reviewers to understand what are the stakes of the pull request.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 21.10.x
  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x (master)

How this pull request can be tested ?

/usr/lib/centreon/plugins//centreon_ibm_storwize_ssh.pl --plugin=storage::ibm::storwize::ssh::plugin --mode=eventlog --hostname='SAN_V7000_CE_CED1' --ssh-backend='sshcli' --ssh-username='nagios.adm' --verbose --retention=3600

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

@y-kacher y-kacher requested review from a team and itoussies September 27, 2023 16:30
@y-kacher y-kacher requested review from a team as code owners December 8, 2023 16:18
@y-kacher y-kacher requested review from sc979 and tuntoja December 8, 2023 16:18
@itoussies itoussies removed their request for review December 8, 2023 16:22
@Evan-Adam
Copy link
Contributor

It seem this plugin always have send wrong date in the output (the decision making for ok/warning/critical don't seem to involve this date). @s-duret could you test with the client this new version and come back to us if it work so we can merge it ?

sc979
sc979 previously approved these changes Dec 8, 2023
Copy link
Contributor

@sc979 sc979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packaging part LGTM

tuntoja
tuntoja previously approved these changes Dec 11, 2023
@Evan-Adam Evan-Adam dismissed stale reviews from tuntoja and sc979 via cc42b9b December 12, 2023 14:48
sdepassio
sdepassio previously approved these changes Jan 12, 2024
@lucie-dubrunfaut lucie-dubrunfaut dismissed stale reviews from sdepassio and themself via 3046e26 January 12, 2024 10:56
@lucie-dubrunfaut lucie-dubrunfaut force-pushed the MON-21973-date-problem-on-storage-ibm-storwize-ssh-plugin-eventlog branch from cc42b9b to 3046e26 Compare January 12, 2024 10:56
@lucie-dubrunfaut lucie-dubrunfaut merged commit dd3f3a3 into develop Jan 12, 2024
10 checks passed
@lucie-dubrunfaut lucie-dubrunfaut deleted the MON-21973-date-problem-on-storage-ibm-storwize-ssh-plugin-eventlog branch January 12, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants