Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kf/standalone electron app #84

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Kf/standalone electron app #84

merged 3 commits into from
Nov 20, 2024

Conversation

KasperFyhn
Copy link
Contributor

Allows for packaging the Visualizer as a standalone Electron app for Windows, Mac or Linux.

@KasperFyhn KasperFyhn added the enhancement New feature or request label Nov 11, 2024
@KasperFyhn
Copy link
Contributor Author

KasperFyhn commented Nov 11, 2024

@KennethEnevoldsen Do you happen to know what is going on with the docformatter pre-commit hook? It seems to be related to this: pre-commit/pre-commit#2734, but I am not sure we can do anything about it.

@KennethEnevoldsen
Copy link
Contributor

I would probably disable pre-commit hooks (generally stopped using them) and instead just create the workflow manually:

https://github.com/KennethEnevoldsen/scandinavian-embedding-benchmark/blob/main/.github/workflows/lint.yml

Where the make refers to a command from a makefile (you can just replace it with bash code). The code that this one calls is the following:

lint-check:
	@echo "--- 🧹 Check is project is linted ---"
	ruff format . --check						    # running ruff formatting
	ruff check **/*.py 						        # running ruff linting

Which uses ruff (which I also recommend).

@KasperFyhn
Copy link
Contributor Author

Yeah, some of these pre-commit hooks can cause more problems than they solve. I will look into it again tomorrow. If there is no obvious solution, I will disable it.

@KasperFyhn KasperFyhn merged commit 2171b6c into main Nov 20, 2024
5 checks passed
@KasperFyhn KasperFyhn deleted the kf/standalone-electron-app branch November 20, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants