Minor cleanups in the tests. (#1066)

census-instrumentation · Mar 15, 2019 · 5439521 · 5439521
1 parent 4c51322
commit 5439521
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/plugin/ochttp/trace_test.go b/plugin/ochttp/trace_test.go
@@ -100,8 +100,7 @@ func TestTransport_RoundTrip_Race(t *testing.T) {
 }
 
 func TestTransport_RoundTrip(t *testing.T) {
-	ctx := context.Background()
-	ctx, parent := trace.StartSpan(ctx, "parent")
+	_, parent := trace.StartSpan(context.Background(), "parent")
 	tests := []struct {
 		name   string
 		parent *trace.Span

diff --git a/resource/resource_test.go b/resource/resource_test.go
@@ -146,7 +146,7 @@ func TestMultiDetector(t *testing.T) {
 	}
 
 	wantErr := errors.New("err1")
-	got, err = MultiDetector(
+	_, err = MultiDetector(
 		func(context.Context) (*Resource, error) {
 			return &Resource{
 				Type:   "t1",

diff --git a/trace/tracestate/tracestate_test.go b/trace/tracestate/tracestate_test.go
@@ -152,6 +152,10 @@ func TestImplicitImmutableTracestate(t *testing.T) {
 
 	// Check Tracestate does not have key3.
 	checkKeyValue(t, tracestate, key3, "", testname)
+	// Check that we added the key3 in the entries
+	tracestate, err = New(nil, entries...)
+	checkError(t, tracestate, err, testname, "create failed")
+	checkKeyValue(t, tracestate, key3, value3, testname)
 }
 
 func TestKeyWithValidChar(t *testing.T) {