Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make install-dir be optional and not required #125

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Make install-dir be optional and not required #125

merged 2 commits into from
Apr 17, 2024

Conversation

pputman-clabs
Copy link
Contributor

No description provided.

@jcortejoso
Copy link
Member

I think it requires a default value for install-dir so it can be used in the step that runs npm install.

@jcortejoso jcortejoso self-requested a review April 17, 2024 14:06
@pputman-clabs pputman-clabs merged commit 485be19 into main Apr 17, 2024
2 checks passed
@jcortejoso jcortejoso deleted the pputman/install-dir-optional branch April 17, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcortejoso jcortejoso jcortejoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pputman-clabs @jcortejoso @pputman12