Fix failing e2e tests in test_viem_tx #293
Merged
+17
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/celo-org/celo-blockchain-planning/issues/844
This PR fixes failing e2e tests
e2e_test/js-tests/test_viem_tx.mjs
Fixes made
send overlapping nonce tx in different currencies
failToBumpCurrencyCap
. The original calculation converted (native token fee) - 1 to the token fee value by multiplying it bynumerator
and dividing it by a largedenominator
. However, this division effectively negated the decrement operation. The new calculation make sure to get a lower fee rather than the given amount.send fee currency tx with just high enough gas price
BigInt
toNumber
because chai'sassert
functions rejectBigInt
arguments for integers comparisonHow to check locally
export NETWORK=alfajores ./e2e_test/run_all_tests.sh viem