GH actions config #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palango
force-pushed
the
palango/gh-actions
branch
9 times, most recently
from
b406f52 to
5f5b955
Compare
carterqw2
reviewed
Nov 13, 2023
carterqw2
suggested changes
Nov 13, 2023
palango
force-pushed
the
palango/gh-actions
branch
from
634817d to
9ff0822
Compare
|
@jcortejoso Since switching to our runners, the e2e test fails because it cannot find the |
palango
force-pushed
the
palango/gh-actions
branch
2 times, most recently
from
8bc8c40 to
9f1e92d
Compare
test test Update .github/workflows/ci.yaml Co-authored-by: Valentin Rodygin <[email protected]> Update .github/workflows/ci.yaml Co-authored-by: Valentin Rodygin <[email protected]>
palango
force-pushed
the
palango/gh-actions
branch
from
9f1e92d to
eb152fb
Compare
|
@jcortejoso @carterqw2 Interesting that our org runners are slower than the native GH runner. Should I switch back?
|
carterqw2
approved these changes
Nov 29, 2023
palango
force-pushed
the
palango/gh-actions
branch
from
eb152fb to
257b1a0
Compare
|
@carterqw2 I removed the CircleCI config file now, so once we merge this we need to remove the requirements for circleCI runs as well (and I guess you're the only one with permissions to do so) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings down runtime of tests from 12:30 to 9:30.