Make tracing work for fee currency txs #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we want to execute fee currency txs in tracing tests, we need a FeeCurrencyContext. Rather then setting a fixed on in the test setup code, it is more flexible to read it from the test JSON file, like all other test input.
Without including it in that case, we would miss out on the fee currency code and state, which would make the prestate useless for executing the tx.
We need to look up the fee currency address before using it, like it is done with the to, from and coinbase.
palango
approved these changes
Aug 30, 2024
| @@ -93,6 +93,8 @@ func newPrestateTracer(ctx *tracers.Context, cfg json.RawMessage) (*tracers.Trac | |||
| OnTxStart: t.OnTxStart, | |||
| OnTxEnd: t.OnTxEnd, | |||
| OnOpcode: t.OnOpcode, | |||
| // Celo | |||
| TraceDebitCredit: true, | |||
There was a problem hiding this comment.
Maybe add an explicit TraceDebitCredit: false to the call tracer as well?
| @@ -158,6 +160,9 @@ func (t *prestateTracer) OnTxStart(env *tracing.VMContext, tx *types.Transaction | |||
| t.lookupAccount(from) | |||
| t.lookupAccount(t.to) | |||
| t.lookupAccount(env.Coinbase) | |||
There was a problem hiding this comment.
When this is added here, should we add accounts which receive fees here as well, like the FeeHandler?
There was a problem hiding this comment.
I only thought about the fee currency txs in this PR, where the FeeHandler is part of the fee currency's storage. But for a normal tx and enables Cel2, that might be necessary. I'll take a look at that case.
|
Todo: should the FeeHandler address show up in the diff mode tracing? EDIT: tipReceiver and baseFeeReceiver are the same in the test, therefore only a single address (plus tx sender) is touched. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69
Added tests for the following tracers: