Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fadeOutAmong bug when sending CELO #167

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Fix fadeOutAmong bug when sending CELO #167

merged 3 commits into from
Mar 29, 2024

Conversation

arthurgousset
Copy link
Contributor

@arthurgousset arthurgousset commented Mar 29, 2024 •
edited
Loading

Description

  • Fixes bug that meant CELO-only requests were not adjusted based on the recipients balance. Now all requests are adjusted based on recipient balance

Other changes

  • Fixes minor typos
  • Leaves TODO to refactor how the adjusted amount should be calculated

Tested

We'll test manually as usual.

Related issues

Backwards compatibility

Yes

Documentation

N/A

@arthurgousset arthurgousset requested a review from a team as a code owner March 29, 2024 13:39
@vercel Vercel
Copy link

vercel bot commented Mar 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
faucet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 1:40pm

@arthurgousset arthurgousset merged commit 0eb2dbb into master Mar 29, 2024
7 checks passed
@arthurgousset arthurgousset deleted the arthurgousset/reduce-faucet-abuse branch March 29, 2024 13:42
@arthurgousset arthurgousset mentioned this pull request Mar 29, 2024
Closed
@arthurgousset arthurgousset self-assigned this Mar 29, 2024
@arthurgousset arthurgousset changed the title Reduce faucet abuse Fix fadeOutAmong bug when sending CELO Mar 29, 2024
@arthurgousset arthurgousset changed the title Fix fadeOutAmong bug when sending CELO Fix fadeOutAmong bug when sending CELO Mar 29, 2024
@arthurgousset arthurgousset mentioned this pull request Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronmgdr aaronmgdr aaronmgdr approved these changes

Assignees

@arthurgousset arthurgousset

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthurgousset @aaronmgdr