Adds Github setup files #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency with other repositories like celo-org/developer-tooling
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aaronmgdr
reviewed
Mar 25, 2024
nicolasbrugneaux
approved these changes
Mar 25, 2024
Good point. I did customise the CONTRIBUTING file for the faucet repo. To the best of my knowledge, the instructions are correct. I agree that the instructions could be more detailed, but in the interest of "some" instructions are better than "no" instructions, I propose we accept these changes. Can you see anything that is not true for this repo @aaronmgdr ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Other changes
None.
Tested
Docs only change.
Related issues
Backwards compatibility
Yes.
Documentation
Yes, changes are docs changes.