-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Info about Easy Fee Tokens / Fee Currencies for L2 #1325
Comments
@aaronmgdr Should we update the docs today? or a few days before Cel2 is available to use? |
These changes id wait until the testnet is ready. |
Now that the testnet is ready, what is the state of this issue? |
Waiting for CIP 66 to be implemented on Dango. |
Ok, then I'll move this to a different epic, since that is not included in the current testnet. |
Please do the changes that don't depend on CIP-66 (FeeCurrencyWhiteList => FeeCurrencyDirectory) now without waiting for CIP-66, since that will still take a while. If that is a signifiant amount of work, consider splitting the issue into two. |
CIP-66 won't be in during the alfajores migration and is also not at the top of the priority list after that. Please don't wait for CIP-66 to update the docs! |
we can close this as cip66 is not real |
For Cel2 some updates are needed to docs when talking about easy fee feature.
In general FeeCurrencyWhiteList => FeeCurrencyDirectory
Please add this to paying for gas in tokens page
Understanding CIP66 vs previous fee currency transaction types
While Celo has had support for paying for gas with specific fee tokens since day 1. the implementation of this feature has gone thru a few iterations of transaction types. CIP 66 aka type 122 has some significant changes to be aware of as a developer.
maxFeePerGas
andmaxPriorityFeePerGas
fields are used and can be built exactly like a EIP 1559 transactions.::info:: when providing
feeCurrency
its safer to either provide all the threemaxFeePerGas
,maxPriorityFeePerGas
andmaxFeeInFeeCurrency
fields yourself or none and let the library calculate them for you. as there could be ambiguity on whether the maxFeePerGas you give the library was calculated in the fee token or in CELO ::info::The text was updated successfully, but these errors were encountered: