-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Telemetry #465
base: master
Are you sure you want to change the base?
[WIP] Telemetry #465
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #465 +/- ##
===========================================
- Coverage 73.53% 56.86% -16.67%
===========================================
Files 241 242 +1
Lines 10212 10265 +53
Branches 1623 1625 +2
===========================================
- Hits 7509 5837 -1672
- Misses 2609 4359 +1750
+ Partials 94 69 -25
|
some thoughts. The info here takes up a lot of space. Im worried people want to opt out just to avoid seeing the annoying warning every time they run a command.
lets discuss solutions |
made discussion to show on message on install, first time the first command is run post install and if telemetry is turned back on |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
14107627 | Triggered | Generic High Entropy Secret | 095058c | packages/cli/src/commands/account/new.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…oling into shazarre/Telemetry
Description
This PR adds telemetry to celocli.
Other changes
Removes unnecessary
postinstall
hook invocation.Tested
Ran tests locally and on CI. Ran actual code locally to make sure telemetry is being sent.
PR-Codex overview
This PR introduces telemetry functionality to the
celocli
tool, enabling anonymous usage statistics collection and providing configuration options for users to enable or disable telemetry.Detailed summary
TELEMETRY_ENABLED
environment variable handling.reportUsageStatisticsIfTelemetryEnabled
function.printTelemetryInformation
for user notifications.CeloConfig
to includetelemetry
property.--telemetry
flag.