FeeCurrencyDirectory support #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e0f7576 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## l2-integrate #236 +/- ##
===============================================
Coverage ? 67.62%
===============================================
Files ? 127
Lines ? 5925
Branches ? 965
===============================================
Hits ? 4007
Misses ? 1837
Partials ? 81 ☔ View full report in Codecov by Sentry. |
aaronmgdr
reviewed
May 10, 2024
|
Workflow is failing with an error:
The reason is (thanks @nicolasbrugneaux!) that right now by introducing unconditional Idea is to refactor the |
|
Follow-up issue related to this PR: |
shazarre
force-pushed
the
shazarre/fee_currency_directory_support
branch
2 times, most recently
from
c9ab25f to
c9c3345
Compare
|
Merging this PR needs to wait until |
shazarre
force-pushed
the
shazarre/fee_currency_directory_support
branch
from
9237088 to
c58a364
Compare
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
aaronmgdr
reviewed
Jun 6, 2024
aaronmgdr
reviewed
Jun 6, 2024
packages/sdk/contractkit/src/wrappers/FeeCurrencyDirectoryWrapper.test.ts
Outdated
Show resolved
Hide resolved
aaronmgdr
reviewed
Jun 6, 2024
packages/sdk/contractkit/src/wrappers/FeeCurrencyDirectoryWrapper.ts
Outdated
Show resolved
Hide resolved
aaronmgdr
reviewed
Jun 6, 2024
packages/sdk/contractkit/src/wrappers/FeeCurrencyDirectoryWrapper.ts
Outdated
Show resolved
Hide resolved
…currency_directory_support
aaronmgdr
pushed a commit
that referenced
this pull request
Jun 17, 2024
aaronmgdr
added a commit
that referenced
this pull request
Jun 24, 2024
* Improve test setup for L2 / anvil (#253) * change setupL2 to only need web3 as that is all it uses and we always have web3 where as sometimes we wee needing to create a kit just to pass it to this function move node experimental setup to the package so its always run and no weird esoteric knowldge is needed to run tests * FeeCurrencyDirectory support (#236) * CLI network commands anvil / L2 (#255) * Anvil Migrate: Fed Attestate (#259) * Add FeeCurrencyDirectoryWrapper config to network:parameters command (#260) * Migrate governance tests to anvil (#263) * Bump up dependencies and move setupL2 (#268) * Contracts, Params and Deprecations notices (#269) Co-authored-by: Leszek Stachowski <[email protected]>
nicolasbrugneaux
added a commit
that referenced
this pull request
Jul 4, 2024
* Improve test setup for L2 / anvil (#253) * set the experimental module always when running tests in cli. * change setupL2 to only need web3 as that is all it uses and we always have web3 where as sometimes we wee needing to create a kit just to pass it to this function move node experimental setup to the package so its always run and no weird esoteric knowldge is needed to run tests * kit not required --------- Co-authored-by: Leszek Stachowski <[email protected]> * FeeCurrencyDirectory support (#236) * CLI network commands anvil / L2 (#255) * dd anvil /l2 test for network commands remove displaying balance of tokens remove epoch info when in L2 context * add changesets * update snap * Anvil Migrate: Fed Attestate (#259) * default to sending v4 of sign typed data switch federated attestations to anvil, * doc around * Add FeeCurrencyDirectoryWrapper config to network:parameters command (#260) * feat: cip66 wip * chore: snapshots oops * fix: dont estimate in @celo/connect * test: modulo 6 🤪 * refactor: less magic strings * docs: regenerate docs * handle large numbers for recovery values * get the exchange rate from the fcd wrapper allow bigint * Improve test setup for L2 / anvil (#253) * set the experimental module always when running tests in cli. * change setupL2 to only need web3 as that is all it uses and we always have web3 where as sometimes we wee needing to create a kit just to pass it to this function move node experimental setup to the package so its always run and no weird esoteric knowldge is needed to run tests * kit not required --------- Co-authored-by: Leszek Stachowski <[email protected]> * FeeCurrencyDirectory support (#236) * CLI network commands anvil / L2 (#255) * dd anvil /l2 test for network commands remove displaying balance of tokens remove epoch info when in L2 context * add changesets * update snap * Anvil Migrate: Fed Attestate (#259) * default to sending v4 of sign typed data switch federated attestations to anvil, * doc around * Add FeeCurrencyDirectoryWrapper config to network:parameters command (#260) * Migrate governance tests to anvil (#263) * test scaffold * i think ill need to merge in the l2 stuff before i cant continue * when a numeric is converted to string if the base is not specified it might try sci notation which is not convertable to big int * fix tests by adding a mock for isCel2 and being sure to only call newKitFromWeb3 once per instances of web3. * docs * add changeset * estimate gas if it is blank. all fee's returned should have same format * Bump up dependencies and move setupL2 (#268) * sneakily convert to anvil * fix calculation * fix slippage padding * docs * more of this * cs * Revert "cs" This reverts commit 00c1238. * Contracts, Params and Deprecations notices (#269) * mark methods for getting epoch from kit as deprecated, have separate sets of arrays for contract configs to be shown via networkConfig method * add change set * fix that poor name * use setupL2 * fix: tests not awaited * fix: tests not awaited * fix: snapshots and add new estimation test * chore: update docs * fix: tests * chore: add changeset * chore: update hw-app-eth * chore: update changeset --------- Co-authored-by: Aaron DeRuvo <[email protected]> Co-authored-by: Leszek Stachowski <[email protected]>
aaronmgdr
added a commit
that referenced
this pull request
Oct 2, 2024
commit 87223ba93ab79f43ae6884282d30a420eb09c23c Author: Aaron DeRuvo <[email protected]> Date: Tue Oct 1 15:05:08 2024 +0200 Remove support for reserve commands. (#339) ### Description Penultimate step of sunsetting the reserve commands. https://forum.celo.org/t/sunset-of-reserve-commands/8454 ### Other changes n/a ### Tested n/a ### Related issues - Fixes https://github.com/celo-org/celo-blockchain-planning/issues/439 ### Backwards compatibility nope ### Documentation docs for commands removed <!-- start pr-codex --> --- ## PR-Codex overview This PR removes the support for `reserve:*` commands in the CLI as part of the deprecation process outlined in a forum discussion. ### Detailed summary - Deleted the following files: - `packages/cli/src/commands/reserve/status.ts` - `packages/cli/src/commands/reserve/transfergold.ts` - `packages/cli/src/commands/reserve/transfergold.test.ts` - Updated the `changeset/gold-pumas-fry.md` to reflect the major version change for `@celo/celocli` and document the removal of `reserve:*` commands. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> commit 416ed00824866f8fdc9449f396ca956294e4f915 Author: Aaron DeRuvo <[email protected]> Date: Tue Oct 1 14:57:39 2024 +0200 remove @celo/rpc-wallet (#342) ### Description As described[ in this form post](https://forum.celo.org/t/deprecation-of-celo-wallet-rpc/8452) the @celo/wallet-rpc package is being removed. `personal_` namespace is deprecated in geth. and already not supported in testing environments like anvil. ### Other changes nope ### Tested n/a ### Related issues - Fixes #257 - fixes https://github.com/celo-org/celo-blockchain-planning/issues/431 ### Backwards compatibility nope ### Documentation docs updated <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on the deletion of various files and directories related to the `wallet-rpc` module in the SDK, indicating a significant removal of components from the project. ### Detailed summary - Deleted the entire `docs/sdk/wallet-rpc` directory, including `README.md` and multiple module documentation files. - Removed the `wallet-rpc` directory from `packages/sdk/wallets`, including its `README.md`, configuration files, and source files. - Eliminated test utility files related to `ganache` in `src/test-utils`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> commit ee8c2ba93f04651356cca83bd5c62047f9556825 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Sep 30 13:15:54 2024 +0200 Version Packages (#349) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. # Releases ## @celo/[email protected] ### Minor Changes - [#348](https://github.com/celo-org/developer-tooling/pull/348) [`76d09b7`](https://github.com/celo-org/developer-tooling/commit/76d09b79c68cbb5aba38c0b36a5322384b7842ba) Thanks [@shazarre](https://github.com/shazarre)! - Adds support for firstKnownEpoch, getFirstBlockAtEpoch, getLastBlockAtEpoch on EpochManager wrapper ### Patch Changes - Updated dependencies \[[`433b70e`](https://github.com/celo-org/developer-tooling/commit/433b70e20563e3e087cc39d744f1a2710d1d09de)]: - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - [#348](https://github.com/celo-org/developer-tooling/pull/348) [`76d09b7`](https://github.com/celo-org/developer-tooling/commit/76d09b79c68cbb5aba38c0b36a5322384b7842ba) Thanks [@shazarre](https://github.com/shazarre)! - Fix network:info command when in L2 - Updated dependencies \[[`433b70e`](https://github.com/celo-org/developer-tooling/commit/433b70e20563e3e087cc39d744f1a2710d1d09de), [`76d09b7`](https://github.com/celo-org/developer-tooling/commit/76d09b79c68cbb5aba38c0b36a5322384b7842ba)]: - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - [#350](https://github.com/celo-org/developer-tooling/pull/350) [`433b70e`](https://github.com/celo-org/developer-tooling/commit/433b70e20563e3e087cc39d744f1a2710d1d09de) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix calculation of maxFeePerGas. Multiple base Fee by constant for buffer <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the versions of the `@celo/connect` and `@celo/contractkit` packages, along with minor bug fixes and improvements in the changelogs for each package. ### Detailed summary - Updated `@celo/connect` from `6.0.1` to `6.0.2` - Updated `@celo/contractkit` from `8.2.0` to `8.3.0` - Updated `@celo/celocli` from `5.2.0` to `5.2.1` - Added changelog entries for versions `6.0.2`, `8.3.0`, and `5.2.1` - Fixed calculation of `maxFeePerGas` in `@celo/connect` - Added support for new methods in `@celo/contractkit` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 433b70e20563e3e087cc39d744f1a2710d1d09de Author: Aaron DeRuvo <[email protected]> Date: Mon Sep 30 12:41:34 2024 +0200 fixes max fee per gas calculation (#350) ### Description we were missing the fact that base fee or gas price should be multipled by some buffer and that priority fee should be added to these when setting max fee per gas. ### Other changes setup tests with realistic values obtained by making rpc call with cast ### Tested see the tests ### Related issues - Fixes https://github.com/celo-org/developer-tooling/issues/227 ### Backwards compatibility yes ### Documentation n/a <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on fixing the calculation of `maxFeePerGas` in the `Connection` class, ensuring it includes a buffer based on the `baseFeePerGas`. It also updates tests to reflect the new logic. ### Detailed summary - Updated `maxFeePerGas` calculation to include a buffer. - Introduced `addBufferToBaseFee` function to apply the buffer. - Modified logic to determine `baseFee` based on `feeCurrency`. - Adjusted tests for `setFeeMarketGas` to validate new calculations. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> commit 76d09b79c68cbb5aba38c0b36a5322384b7842ba Author: Leszek Stachowski <[email protected]> Date: Fri Sep 27 15:03:06 2024 +0200 Refactor network:info for L2 epochs (#348) commit 431c8c538a40c9a97f3343c249adf9bdad5c7b31 Author: Leszek Stachowski <[email protected]> Date: Thu Sep 26 11:36:31 2024 +0200 Update actions/cache to v4 (#346) ### Description This PR aims to speed up the overall build time by switching cache action version to v4. The problem with previous version was that post restore steps were unexpectedly slow. On the new version this does not seem to be a problem anymore. ### Other changes None. ### Tested Ran CI multiple times. <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the version of the `actions/cache` used in the GitHub Actions workflow from `v3` to `v4` for both the node cache and the build artifacts cache. ### Detailed summary - Updated `actions/cache` version from `v3` to `v4` for the `Restore node cache` step. - Updated `actions/cache` version from `v3` to `v4` for the `Restore build artifacts cache` step. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> commit 724af5ebb344ce6be6dd000d075487e6e0dc55a5 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Sep 26 11:09:45 2024 +0200 Version Packages (#341) commit 740046755f5079cb1dafdb71fcc92cc4ad213eb9 Author: pahor167 <[email protected]> Date: Thu Sep 26 10:33:03 2024 +0200 Epoch Manager algorithm (#334) commit f5e010193bbf23a1da170c76bc21b1953b58fcc5 Author: Leszek Stachowski <[email protected]> Date: Wed Sep 11 13:33:12 2024 +0200 celocli: display URL to create a bug report when error occurs (#336) commit 717809e81cedf17048d524dc7603473fbb11e22c Author: Aaron DeRuvo <[email protected]> Date: Tue Sep 10 16:48:21 2024 +0200 fix it so that when values are printed the order of numbers is numeric (#338) ### Description If a list of values was printed that were keyed by numbers such as transactions to be executed in a governance proposal, they would be ordered incorrectly due to numbers being treated like strings. EG `1, 11, 12, 2,3, 4` this fixes that. <!-- start pr-codex --> --- ## PR-Codex overview This PR fixes the printing of values in numerical order in the `printValueMapRecursive` function in the `cli.ts` file. ### Detailed summary - Fixed sorting of values in `printValueMapRecursive` function to order numeric keys correctly - Added tests for printing number keys in numeric order commit 2c00a44d31efe46eac3250911f69795f644bc286 Author: Leszek Stachowski <[email protected]> Date: Thu Aug 29 15:42:11 2024 +0200 Finalize anvil migration (#335) commit 29ea8c362ef0972dd12f8fc6a172515870b8534f Author: Leszek Stachowski <[email protected]> Date: Thu Aug 29 13:41:02 2024 +0200 Migrate StableTokenWrapper tests to anvil (#326) commit 467d4e16444535d341bd2296d41c386f1dab187f Author: Leszek Stachowski <[email protected]> Date: Mon Aug 26 17:12:55 2024 +0200 Migrate SortedOraclesWrapper tests to anvil (#333) commit a3f9a888e3f9ea9dd7680084721d8e35558aede9 Author: Leszek Stachowski <[email protected]> Date: Wed Aug 21 13:43:36 2024 +0200 Migrate releasecelo command tests to anvil (#331) commit 2478aa6328a0ff846427f9cf7737db78aeb46f9e Author: Leszek Stachowski <[email protected]> Date: Tue Aug 20 14:46:33 2024 +0200 Migrate CLI validator, validatorgroup and election commands to anvil (#330) commit 13ffd5955d5afad0a3ec6d5235cd13afa13e8eeb Author: Leszek Stachowski <[email protected]> Date: Tue Aug 20 14:21:21 2024 +0200 Migrate ElectionWrapper to anvil (#329) commit eb1b84284347f058f2086a45551e15a8da2421a6 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Aug 14 13:29:17 2024 +0200 Version Packages (#325) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. # Releases ## @celo/[email protected] ### Patch Changes - [#315](https://github.com/celo-org/developer-tooling/pull/315) [`dd67b8f`](https://github.com/celo-org/developer-tooling/commit/dd67b8f7e65285d86af277c1172e760f250abd78) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - chore: bump oclif - [#275](https://github.com/celo-org/developer-tooling/pull/275) [`ac736ff`](https://github.com/celo-org/developer-tooling/commit/ac736ff5d1c5cb5457d4c3a856bf75675841b379) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - network:whitelist now outputs as a table accepting typical table formatting flags such as --csv - [#316](https://github.com/celo-org/developer-tooling/pull/316) [`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - fix: Change transfer:celo to use native sendTransaction to save up on gas costs as well as better decoding on ledger - [#313](https://github.com/celo-org/developer-tooling/pull/313) [`7715590`](https://github.com/celo-org/developer-tooling/commit/7715590b3efda1eb39a2600ffc858905265f5d12) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - chore: Deprecate reserve commands see <https://forum.celo.org/t/sunset-of-reserve-commands/8454> - [#315](https://github.com/celo-org/developer-tooling/pull/315) [`dd67b8f`](https://github.com/celo-org/developer-tooling/commit/dd67b8f7e65285d86af277c1172e760f250abd78) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - chore: Upgrade mento packages. version before was accidentally trying to use a dev dependency. (fix husky not installed on install error) - Updated dependencies \[[`dd67b8f`](https://github.com/celo-org/developer-tooling/commit/dd67b8f7e65285d86af277c1172e760f250abd78), [`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - [#314](https://github.com/celo-org/developer-tooling/pull/314) [`053d2b1`](https://github.com/celo-org/developer-tooling/commit/053d2b1eff1460dba8749c9a03c806f20d8112e9) Thanks [@shazarre](https://github.com/shazarre)! - Introduces testWithAnvilL1 and testWithAnvilL2 that replace previously used testWithAnvil to make it explicit in which context given test suite is being run. - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - [#316](https://github.com/celo-org/developer-tooling/pull/316) [`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Fix the logic to fetch maxFeePerGas ## @celo/[email protected] ### Patch Changes - [#315](https://github.com/celo-org/developer-tooling/pull/315) [`dd67b8f`](https://github.com/celo-org/developer-tooling/commit/dd67b8f7e65285d86af277c1172e760f250abd78) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - chore (bump deps) - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`dd67b8f`](https://github.com/celo-org/developer-tooling/commit/dd67b8f7e65285d86af277c1172e760f250abd78), [`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`dd67b8f`](https://github.com/celo-org/developer-tooling/commit/dd67b8f7e65285d86af277c1172e760f250abd78), [`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[]: - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - [#313](https://github.com/celo-org/developer-tooling/pull/313) [`7715590`](https://github.com/celo-org/developer-tooling/commit/7715590b3efda1eb39a2600ffc858905265f5d12) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - chore: Deprecate @celo/wallet-rpc see <https://forum.celo.org/t/deprecation-of-celo-wallet-rpc/8452> - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] <!-- start pr-codex --> --- ## PR-Codex overview This PR updates package versions and dependencies across multiple SDK modules. ### Detailed summary - Updated dependencies for various packages to version 6.0.1 - Added new versions for `@celo/connect`, `@celo/wallet-base`, `@celo/wallet-hsm`, `@celo/wallet-remote` - Patched changes in `@celo/dev-utils`, `@celo/keystores`, `@celo/explorer`, `@celo/governance`, `@celo/contractkit` - Deprecated `@celo/wallet-rpc` > The following files were skipped due to too many changes: `packages/sdk/explorer/package.json`, `packages/sdk/transactions-uri/package.json`, `packages/sdk/wallets/wallet-hsm-azure/package.json`, `packages/sdk/wallets/wallet-rpc/package.json`, `packages/sdk/contractkit/package.json`, `packages/sdk/wallets/wallet-ledger/package.json`, `packages/cli/package.json`, `packages/cli/CHANGELOG.md`, `yarn.lock` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 4274299da1f5bf18ed578ed135e962cdf50f37ef Author: Aaron DeRuvo <[email protected]> Date: Wed Aug 14 12:44:53 2024 +0200 improve changesets and exit beta (#324) ### Description Its time for release! ### Other changes I thought the changesets could use some work ### Tested been testing out the commands with and without my ledger on celocli <!-- start pr-codex --> --- ## PR-Codex overview The focus of this PR is to make chore and fix adjustments to deprecate commands, upgrade packages, and improve gas costs in the codebase. ### Detailed summary - Changed deprecation messages to start with "chore" - Updated transfer method to save on gas costs - Upgraded mento packages to fix installation error - Modified cron job workflow to install `node-gyp` globally > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> commit 80f2c5b5d165ea348479b0a6ebe63519a8f860e1 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Aug 12 15:26:15 2024 +0200 Version Packages (beta) (#309) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. ⚠️⚠️⚠️⚠️⚠️⚠️ `master` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `master`. ⚠️⚠️⚠️⚠️⚠️⚠️ # Releases ## @celo/[email protected] ### Patch Changes - [#315](https://github.com/celo-org/developer-tooling/pull/315) [`dd67b8f`](https://github.com/celo-org/developer-tooling/commit/dd67b8f7e65285d86af277c1172e760f250abd78) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - chore: bump oclif - [#275](https://github.com/celo-org/developer-tooling/pull/275) [`ac736ff`](https://github.com/celo-org/developer-tooling/commit/ac736ff5d1c5cb5457d4c3a856bf75675841b379) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - network:whitelist now outputs as a table accepting typical table formatting flags such as --csv - [#316](https://github.com/celo-org/developer-tooling/pull/316) [`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Change transfer:celo to use native sendTransaction to save up on gas costs as well as better decoding on ledger - [#313](https://github.com/celo-org/developer-tooling/pull/313) [`7715590`](https://github.com/celo-org/developer-tooling/commit/7715590b3efda1eb39a2600ffc858905265f5d12) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Deprecate reserve commands see <https://forum.celo.org/t/sunset-of-reserve-commands/8454> - [#315](https://github.com/celo-org/developer-tooling/pull/315) [`dd67b8f`](https://github.com/celo-org/developer-tooling/commit/dd67b8f7e65285d86af277c1172e760f250abd78) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Upgrade mento packages. version before was accidentally trying to use a dev dependency. (fix husky not installed on install error) - Updated dependencies \[[`dd67b8f`](https://github.com/celo-org/developer-tooling/commit/dd67b8f7e65285d86af277c1172e760f250abd78), [`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - [#314](https://github.com/celo-org/developer-tooling/pull/314) [`053d2b1`](https://github.com/celo-org/developer-tooling/commit/053d2b1eff1460dba8749c9a03c806f20d8112e9) Thanks [@shazarre](https://github.com/shazarre)! - Introduces testWithAnvilL1 and testWithAnvilL2 that replace previously used testWithAnvil to make it explicit in which context given test suite is being run. - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - [#316](https://github.com/celo-org/developer-tooling/pull/316) [`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Fix the logic to fetch maxFeePerGas ## @celo/[email protected] ### Patch Changes - [#315](https://github.com/celo-org/developer-tooling/pull/315) [`dd67b8f`](https://github.com/celo-org/developer-tooling/commit/dd67b8f7e65285d86af277c1172e760f250abd78) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - chore (bump deps) - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`dd67b8f`](https://github.com/celo-org/developer-tooling/commit/dd67b8f7e65285d86af277c1172e760f250abd78), [`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`dd67b8f`](https://github.com/celo-org/developer-tooling/commit/dd67b8f7e65285d86af277c1172e760f250abd78), [`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[]: - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - [#313](https://github.com/celo-org/developer-tooling/pull/313) [`7715590`](https://github.com/celo-org/developer-tooling/commit/7715590b3efda1eb39a2600ffc858905265f5d12) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Deprecate @celo/wallet-rpc see <https://forum.celo.org/t/deprecation-of-celo-wallet-rpc/8452> - Updated dependencies \[[`d245703`](https://github.com/celo-org/developer-tooling/commit/d245703fa71ad24c88982fc6566e4d2865f586a4)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] <!-- start pr-codex --> --- ## PR-Codex overview This PR updates various packages to version 6.0.1-beta.0, including dependencies like `@celo/connect` and `@celo/wallet-base`. ### Detailed summary - Updated packages to version 6.0.1-beta.0 - Updated dependencies for multiple packages - Added new changesets for version 6.0.0 > The following files were skipped due to too many changes: `packages/sdk/explorer/package.json`, `packages/sdk/transactions-uri/package.json`, `packages/sdk/wallets/wallet-hsm-azure/package.json`, `packages/sdk/wallets/wallet-rpc/package.json`, `packages/sdk/contractkit/package.json`, `packages/sdk/wallets/wallet-ledger/package.json`, `packages/cli/package.json`, `packages/cli/CHANGELOG.md`, `yarn.lock` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit c5b40974735b368c957b1a255b111432333333e4 Author: Aaron DeRuvo <[email protected]> Date: Mon Aug 12 12:30:42 2024 +0200 fix the failing renovate validation check (#322) ### Description our validation check for the renovate config has been failing. 1. use a specific gh action since calling the npx action now requires some other config to work 2. the schema needed to be migrated <!-- start pr-codex --> --- ## PR-Codex overview The focus of this PR is to update Renovate configuration and CI workflow setup. ### Detailed summary - Updated Renovate base configuration - Changed Node setup in CI workflow - Added validation steps for team and repo configurations in CI workflow > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> commit 20332dbab50ab08e26a2b2a122df087668daf61d Author: Aaron DeRuvo <[email protected]> Date: Mon Aug 12 12:20:05 2024 +0200 enter beta mode and fix typo (#321) ### Description Merging this pr will automatically create a Version Packages Beta pr which we will then merge to release betas of all packages that get an update ### Other changes typo in command it is singular not plural <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the initial versions of various packages to prepare for a beta release. ### Detailed summary - Updated initial versions for multiple packages in `.changeset/pre.json` - Added `"mode": "pre"` and `"tag": "beta"` to the changeset metadata > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> commit dd67b8f7e65285d86af277c1172e760f250abd78 Author: Aaron DeRuvo <[email protected]> Date: Thu Aug 8 16:03:41 2024 +0200 upgrade dependencies + update docs on releasing (#315) * outlines full process for releasing (not jus the technical part) * upgrades mento and oclif dependencies as these had subdeps that were giving warnings on install * test package install with npm intead of yarn as its more generic/ offers better chance to catch bugs <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on upgrading and fixing dependencies in the project. ### Detailed summary - Upgraded `@celo/celocli` and `@celo/odis-identifiers` dependencies - Fixed an error with `husky` not being installed on initial setup - Updated various CLI commands with gas currency values and addresses - Updated various OCLIF plugins and packages to their latest versions > The following files were skipped due to too many changes: `docs/command-line-interface/oracle.md`, `docs/command-line-interface/network.md`, `RELEASE.md`, `docs/command-line-interface/dkg.md`, `docs/command-line-interface/exchange.md`, `docs/command-line-interface/validatorgroup.md`, `docs/command-line-interface/election.md`, `docs/command-line-interface/transfer.md`, `docs/command-line-interface/lockedgold.md`, `docs/command-line-interface/plugins.md`, `docs/sdk/contractkit/classes/kit.ContractKit.md`, `docs/command-line-interface/validator.md`, `docs/command-line-interface/releasecelo.md`, `docs/command-line-interface/governance.md`, `docs/command-line-interface/account.md`, `yarn.lock` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> --------- Co-authored-by: Victoria <[email protected]> commit d245703fa71ad24c88982fc6566e4d2865f586a4 Author: Nicolas Brugneaux <[email protected]> Date: Thu Aug 8 13:47:11 2024 +0200 fix: gas price estimation and native transfer (#316) WIP: gas estimations for the CLI refactor <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on improving gas cost optimization and enhancing transaction logic in Celo SDK and CLI. ### Detailed summary - Improved logic to fetch `maxFeePerGas` - Updated `transfer:celo` to use native `sendTransaction` - Added mocks for gas price and maxPriorityFeePerGas - Enhanced gas cost optimization in various functions > The following files were skipped due to too many changes: `docs/sdk/connect/classes/connection.Connection.md` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> --------- Co-authored-by: Aaron DeRuvo <[email protected]> commit 7715590b3efda1eb39a2600ffc858905265f5d12 Author: Aaron DeRuvo <[email protected]> Date: Mon Jul 29 14:35:20 2024 +0200 Deprecation Notices (#313) Adds changesets which contain deprecation notices to the wallet-rpc package and the reserve command in the cli <!-- start pr-codex --> --- ## PR-Codex overview This PR deprecates the reserve commands and `@celo/wallet-rpc`. ### Detailed summary - Deprecated reserve commands with forum links - Deprecated `@celo/wallet-rpc` with forum links - Updated deprecation warnings in code and documentation > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 053d2b1eff1460dba8749c9a03c806f20d8112e9 Author: Leszek Stachowski <[email protected]> Date: Fri Jul 26 15:36:49 2024 +0200 Use L2 devchain (#314) commit def3f2d991d98ae51b6eb8290d2c5665bdb723bc Author: Leszek Stachowski <[email protected]> Date: Thu Jul 25 16:39:21 2024 +0200 Separate anvil and ganache tests (#307) commit ac736ff5d1c5cb5457d4c3a856bf75675841b379 Author: Aaron DeRuvo <[email protected]> Date: Wed Jul 24 14:54:46 2024 +0200 display whitelist as table (#275) * switches output of whitelist to a table as is standard for the cli also perhapse these columns headers are more understandable * add flags * add changeset * now test tables * update docs commit 2c028d04039e5066556f4f5f08866c6b55ae91f3 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jul 24 14:21:09 2024 +0200 Version Packages (#300) * Version Packages * fix: modify yarn.lock to fix dependencies --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nicolas Brugneaux <[email protected]> commit 9d9cf4ff9a5452b20c5b768e36be8e7059d01f95 Author: Nicolas Brugneaux <[email protected]> Date: Wed Jul 24 11:26:41 2024 +0200 chore: exit beta (#306) commit de1e5a02bb0361aa42b486e9227222b20dfb8416 Author: Nicolas Brugneaux <[email protected]> Date: Wed Jul 24 11:09:33 2024 +0200 Fix/allow approval in execution (#296) * feat: add proposal checker with multiple allowed stages * fix: mimic code style better * test: add approval tests * test: snapshots oops * chore: add changeset * chore: snapshots * fix: changeset typo * fix: use impersonateAccount and add a balance helper * fix: hex -> number/bigint/bignumber --------- Co-authored-by: bowd <[email protected]> Co-authored-by: boqdan <[email protected]> commit 6d6c3fbf1917a66f93772e7484310bce0df9414d Author: Leszek Stachowski <[email protected]> Date: Tue Jul 23 14:47:32 2024 +0200 @celo/contractkit: migrate Governance wrapper tests to anvil (#305) commit 17f48bcb9750c8c40d65e909677230d4dde4d39b Author: Leszek Stachowski <[email protected]> Date: Fri Jul 19 15:14:54 2024 +0200 Migrate tests to anvil (#299) commit 06019bfce3d7d939aca8d04d841193eb733bd372 Author: Leszek Stachowski <[email protected]> Date: Fri Jul 19 14:56:01 2024 +0200 L2 hotfix (#279) commit 041886c88fc5a31cfa4c9987ec05e6661b349c4c Author: Aaron DeRuvo <[email protected]> Date: Mon Jul 15 13:18:53 2024 +0200 there seems to be something stuck where renovate is not creating prs even when approved on the dashboard. so we will no longer wait for approval (#295) commit 75b2749a2f7c8e12795ac57cdfbc9d2a2f582459 Author: Leszek Stachowski <[email protected]> Date: Mon Jul 15 08:41:04 2024 +0200 Fix yarn resolution errors (#293) * Fix yarn resolution errors * remove comment and flag for CI commit 247f40558855dc7fd32a0fef1133454a844a75f3 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jul 4 10:25:20 2024 +0000 Version Packages (beta) (#289) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit d5b1508d7d08a99f6bb6deb569ec8b89194de2b9 Author: Nicolas Brugneaux <[email protected]> Date: Thu Jul 4 11:55:31 2024 +0200 fix: ledger git url (#288) * fix: ledger git url * chore: add changeset commit 8e783d9b16a50bba92fc000776c476dc07036e7b Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jul 4 09:14:20 2024 +0000 Version Packages (beta) (#287) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 59f4b42029699861e91dd2214c40173f70de279e Author: Nicolas Brugneaux <[email protected]> Date: Thu Jul 4 10:59:14 2024 +0200 Add Support for CIP66 in @celo/* (#264) * Improve test setup for L2 / anvil (#253) * set the experimental module always when running tests in cli. * change setupL2 to only need web3 as that is all it uses and we always have web3 where as sometimes we wee needing to create a kit just to pass it to this function move node experimental setup to the package so its always run and no weird esoteric knowldge is needed to run tests * kit not required --------- Co-authored-by: Leszek Stachowski <[email protected]> * FeeCurrencyDirectory support (#236) * CLI network commands anvil / L2 (#255) * dd anvil /l2 test for network commands remove displaying balance of tokens remove epoch info when in L2 context * add changesets * update snap * Anvil Migrate: Fed Attestate (#259) * default to sending v4 of sign typed data switch federated attestations to anvil, * doc around * Add FeeCurrencyDirectoryWrapper config to network:parameters command (#260) * feat: cip66 wip * chore: snapshots oops * fix: dont estimate in @celo/connect * test: modulo 6 🤪 * refactor: less magic strings * docs: regenerate docs * handle large numbers for recovery values * get the exchange rate from the fcd wrapper allow bigint * Improve test setup for L2 / anvil (#253) * set the experimental module always when running tests in cli. * change setupL2 to only need web3 as that is all it uses and we always have web3 where as sometimes we wee needing to create a kit just to pass it to this function move node experimental setup to the package so its always run and no weird esoteric knowldge is needed to run tests * kit not required --------- Co-authored-by: Leszek Stachowski <[email protected]> * FeeCurrencyDirectory support (#236) * CLI network commands anvil / L2 (#255) * dd anvil /l2 test for network commands remove displaying balance of tokens remove epoch info when in L2 context * add changesets * update snap * Anvil Migrate: Fed Attestate (#259) * default to sending v4 of sign typed data switch federated attestations to anvil, * doc around * Add FeeCurrencyDirectoryWrapper config to network:parameters command (#260) * Migrate governance tests to anvil (#263) * test scaffold * i think ill need to merge in the l2 stuff before i cant continue * when a numeric is converted to string if the base is not specified it might try sci notation which is not convertable to big int * fix tests by adding a mock for isCel2 and being sure to only call newKitFromWeb3 once per instances of web3. * docs * add changeset * estimate gas if it is blank. all fee's returned should have same format * Bump up dependencies and move setupL2 (#268) * sneakily convert to anvil * fix calculation * fix slippage padding * docs * more of this * cs * Revert "cs" This reverts commit 00c12383745e29117536d73a78e6f26bc98bdd79. * Contracts, Params and Deprecations notices (#269) * mark methods for getting epoch from kit as deprecated, have separate sets of arrays for contract configs to be shown via networkConfig method * add change set * fix that poor name * use setupL2 * fix: tests not awaited * fix: tests not awaited * fix: snapshots and add new estimation test * chore: update docs * fix: tests * chore: add changeset * chore: update hw-app-eth * chore: update changeset --------- Co-authored-by: Aaron DeRuvo <[email protected]> Co-authored-by: Leszek Stachowski <[email protected]> commit c38ff3b5aad4538fe14e61c791991c2126f3ff8a Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jul 4 06:19:31 2024 +0000 Version Packages (beta) (#286) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit cae3f8097805c2ba2cea6fed48356781728ff4dd Author: Nicolas Brugneaux <[email protected]> Date: Thu Jul 4 07:49:57 2024 +0200 Nicolasbrugneaux/celocli ledger release (#285) * chore: update hw-app-eth * chore: add changeset * chore: update deps commit a5ffcb662906d4674a7dd76c0c70e21fc4186534 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jul 3 18:43:21 2024 +0200 Version Packages (beta) (#284) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 6d2a838a80a51007d75768c77d62a861f2cec136 Author: Nicolas Brugneaux <[email protected]> Date: Wed Jul 3 18:27:53 2024 +0200 chore: add changeset (#283) commit 98a75141977b9da7c01973c53e34da90d0ac3e42 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jul 3 11:20:24 2024 +0200 Version Packages (beta) (#280) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 1a741de728408a27c613868946d20cc85edb4593 Author: Nicolas Brugneaux <[email protected]> Date: Wed Jul 3 10:57:29 2024 +0200 Fix/ledger patch (#282) * fix: ledger patching -> ledger fork * fix: pin commit * fix: no more hoisting * Revert "fix: no more hoisting" This reverts commit df830522d595ba52b7faf78554fb7c0a15288c64. * fix: no more hoisting and update hw-app-eth * fix: checksumBehavior for CI * chore: update hw-app-eth * chore: update docs commit 3f5f65d7328117e92a870a3f14124c68ee03c182 Author: Aaron DeRuvo <[email protected]> Date: Thu Jun 27 18:29:59 2024 +0300 convert transaction-utils to anvil (#278) * convert transaction-utils to anvil fix anvil not closing within jest 1 second timeout by setting anvil timeout to 1 second too. * celo-devchain not needed anymore but it was accidentally providing bn types so those must be added * convert transaction-utils to anvil fix anvil not closing within jest 1 second timeout by setting anvil timeout to 1 second too. * celo-devchain not needed anymore but it was accidentally providing bn types so those must be added * why are these in the docs at all * Update packages/dev-utils/src/test-utils.ts Co-authored-by: Leszek Stachowski <[email protected]> --------- Co-authored-by: Leszek Stachowski <[email protected]> commit ee597c0860710e1823dd691be60559ea49882d0d Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jun 26 17:07:46 2024 +0000 Version Packages (beta) (#213) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nicolas Brugneaux <[email protected]> commit f553539feb68f0be9e91f83bf367b0c32f940d1e Author: Leszek Stachowski <[email protected]> Date: Wed Jun 26 17:41:56 2024 +0200 Add CeloDistributionSchedule support (#267) commit bfa24da3eef5f9386395b2173ced2cfd0a4b0eb2 Author: Aaron DeRuvo <[email protected]> Date: Wed Jun 26 16:11:43 2024 +0300 fix tether display (#274) * usdt adapter implemented this external view function using slightly different name than usdc so we are hacking it support both here https://github.com/orgs/celo-org/projects/174/views/37?pane=issue&itemId=67981300 commit 8462128dc558f4f1e4621ca1cb92b9265e8dbf9c Author: Nicolas Brugneaux <[email protected]> Date: Wed Jun 26 13:23:25 2024 +0200 fix: sort signers (#277) commit 182bf73209e6b7de0d9ea1fedaf91c9ec80299f5 Author: Aaron DeRuvo <[email protected]> Date: Mon Jun 24 18:03:08 2024 +0300 L2 sidework (#266) * Improve test setup for L2 / anvil (#253) * change setupL2 to only need web3 as that is all it uses and we always have web3 where as sometimes we wee needing to create a kit just to pass it to this function move node experimental setup to the package so its always run and no weird esoteric knowldge is needed to run tests * FeeCurrencyDirectory support (#236) * CLI network commands anvil / L2 (#255) * Anvil Migrate: Fed Attestate (#259) * Add FeeCurrencyDirectoryWrapper config to network:parameters command (#260) * Migrate governance tests to anvil (#263) * Bump up dependencies and move setupL2 (#268) * Contracts, Params and Deprecations notices (#269) Co-authored-by: Leszek Stachowski <[email protected]> commit f8e765155d2f1996b889af15e430b0c2a3b34dea Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jun 24 15:43:21 2024 +0300 fix(deps): update dependency @azure/identity to v4.2.1 [security] (#273) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 66972ebf0dfabc845ae309c2f794fe015ac49a86 Author: Nicolas Brugneaux <[email protected]> Date: Mon Jun 24 13:27:25 2024 +0200 Ledger upgrade (#239) * removes support for signing celo legacy and cip42 transactions. support for recovering aka unserializing these old formats remains as someone might want to parse a historic transaction * feat: add decimals to feecurrencywhitelist * chore: add script that creates the unsigned data blob * feat: update ledger package to match blooo's app * chore: update docs * fix: azure tests * fix: celo-provider-tests * feat: add data blob as a npm package * SUPPORT multiple ledger versions (#265) * fix: leftover from revert * fix: patch-package for celo-legacy * fixing ci for ledger (#272) * docs and add dev-utils as dep where it was missing * clear all mocks and timers after each test run upgrade jest and related to latest add workerIdleMemoryLimit without this the heap is overfilled and it crashes --------- Co-authored-by: Aaron DeRuvo <[email protected]> commit 2f7e5f6e6a06c632409a5a6157917991a1d18e0f Author: Arthur Gousset <[email protected]> Date: Thu Jun 20 09:12:49 2024 +0100 refactor(workflows/ci): reads supported Foundry version from env variable (#271) commit 6c2e47d8c8346f1362869bfb59fde952767fe4c5 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed Jun 12 10:40:30 2024 +0300 fix(deps): update dependency @azure/identity to v4.2.1 [security] (#262) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 4007db23d87b36624cd3a17fd429a4507d2e284b Author: Arthur Gousset <[email protected]> Date: Tue Jun 11 15:40:28 2024 +0100 docs: fixes small typo in URLs of various READMEs (#258) commit 092512da2c46987b0c44381aa8303f17603a1c1a Author: Leszek Stachowski <[email protected]> Date: Fri Jun 7 14:56:33 2024 +0200 Run celocli and contractkit tests always (#252) commit 282a0948d7387f1f31aabf8288f7492330a17173 Author: Leszek Stachowski <[email protected]> Date: Thu Jun 6 09:47:11 2024 +0200 Migrate more tests to anvil (#249) commit 2a174cd83437300fd4e5545000c80f7651849746 Author: Leszek Stachowski <[email protected]> Date: Tue Jun 4 12:57:01 2024 +0200 Use @celo/devchain-anvil package (#251) commit 305e27889176e9ea9654bfa3c32537844d68846a Author: Leszek Stachowski <[email protected]> Date: Wed May 22 12:59:19 2024 +0200 Migrate account:register to anvil (#243) commit 6314e2e9496fc93299aa92f03834d37242448461 Author: Aaron DeRuvo <[email protected]> Date: Tue May 21 18:46:51 2024 +0200 Replace homepage for npm packages (#245) * remove leftover refs to read the docs site * Update packages/sdk/network-utils/package.json Co-authored-by: Arthur Gousset <[email protected]> --------- Co-authored-by: Arthur Gousset <[email protected]> commit 3aa75c741b7d29e5da829bb61ed87b9aa6e3bd27 Author: Arthur Gousset <[email protected]> Date: Thu May 16 16:57:54 2024 +0100 Enter Beta Mode (#242) commit d9393d0d8ab888f4576e73d8fe32b36d2cd9d697 Author: Nicolas Brugneaux <[email protected]> Date: Thu May 16 17:00:28 2024 +0200 Docs typos 2 the electric boogaloo (#241) * chore: regenerate docs * fix: change the path of the docs diffing commit d05deabe1c7aa4f14a147573c74191a31c94503b Author: Arthur Gousset <[email protected]> Date: Thu May 16 10:27:30 2024 +0100 Fix @celo/base docs (#240) * chore(sdk/base): fix typo in typedoc output path * docs(sdk/base): re-generates docs at new output path Re-generates docs at `./docs/` ```sh $ yarn workspace @celo/base docs ``` commit 97b5b7b52aceffa3e1f8204658966a0059d2ae51 Author: Arthur Gousset <[email protected]> Date: Wed May 15 12:27:37 2024 +0100 Move docs folder to the top-level folder (#238) * chore(docs/sdk): removes "readthedocs" related configs * chore(sdk): edits typedoc output path config * docs(sdk/base): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * chore(sdk): edits typedoc output path config For `wallet-...` packages * docs(sdk/connect): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * docs(sdk/contractkit): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * docs(sdk/cryptographic-utils): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * docs(sdk/explorer): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * docs(sdk/governance): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * docs(sdk/keystores): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * docs(sdk/network-utils): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * docs(sdk/phone-utils): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * docs(sdk/transactions-uri): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * docs(sdk/utils): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * docs(sdk/wallet-base): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * docs(sdk/wallet-hsm): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * docs(sdk/wallet-hsm-aws): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * docs(sdk/wallet-hsm-azure): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * docs(sdk/wallet-hsm-gcp): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * docs(sdk/wallet-ledger): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * docs(sdk/wallet-local): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * docs(sdk/wallet-remote): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * docs(sdk/wallet-rpc): re-generates docs at new output path 1. Deletes docs at `packages/docs/sdk/docs/` 2. Re-generates docs using `yarn docs` at `packages/docs/sdk/` * docs(sdk): removes 2x (old) READMEs Their information is captured by the README in the root directory. * chore(sdk): updates typedoc output paths * docs(sdk): re-generates docs at new output path 1. Deletes docs at `packages/docs/` ```sh $ rm -rf packages/docs/ ``` 2. Re-generates docs at `./docs/` ```sh $ yarn workspaces foreach --all --parallel --include '@celo/*' run docs ``` * chore(cli): updates oclif docs output path * chore(workflows/open-docs-pr): updates docs path to CLI docs * chore(git): removes uncommented git attributes * chore(git): removes non-existing files from gitattributes commit a172760c35a5dc2dd47045dc7f45c022a15d69ca Author: Arthur Gousset <[email protected]> Date: Wed May 15 11:41:18 2024 +0100 chore(docs/sdk): removes "readthedocs" related configs (#237) commit ee48c33df230bcd2764b039e77d16ec1130173c1 Author: Arthur Gousset <[email protected]> Date: Tue May 14 11:26:12 2024 +0100 Fix typos in CLI docstrings (#232) * style(cli): fix typos * chore(cli): adds back `any` type mistakenly deleted by linter Mistakenly deleted by the linter in this commit 7ad20991e6864f9e38025757b5d82eec2b65a9bf when saving. Quick fix was to disable `formatOnSave` in `.vscode/settings.json`: ```diff "[typescript]": { + "editor.formatOnSave": false, - "editor.formatOnSave": true, ``` * fix cli doc gen * regen on new build * docs(cli/generate_docs): remove code comment Co-authored-by: Leszek Stachowski <[email protected]> * docs(cli/generate_docs): remove code comment Co-authored-by: Leszek Stachowski <[email protected]> * docs(cli/generate_docs): remove code comment Co-authored-by: Leszek Stachowski <[email protected]> * docs(cli/generate_docs): remove code comment Co-authored-by: Leszek Stachowski <[email protected]> --------- Co-authored-by: Aaron DeRuvo <[email protected]> Co-authored-by: Leszek Stachowski <[email protected]> commit eeb44f300c08250e179b43881ae83bf0b530dc67 Author: Arthur Gousset <[email protected]> Date: Fri May 10 12:05:17 2024 +0100 feat: `--useMultiSig` support for governance proposals (#233) * feat(cli/governance:propose): adds MultiSig.sol support Also refactors checks to account for possible multisig proposer. * chore(cli/governance:propose): updates CLI docs example 1. Increases `--deposit` from `10000` to `10000e18` to match current minimum (10,000 CELO) 2. Adds example with `--useMultiSig` * style(cli/governance:approve): linting * feat(cli/governance:propose): adds `--for` multisig flag to fix bug * style(cli/governance:approve): linting * chore(contractkit+cli): fix `isOwner` camel-case function name * docs(contractkit): adds docs with `isOwner` fix * test(cli/governance:propose): adds WIP test with TODO * test(cli/governance:propose): adds MVP multisig creation (n=1) Test passes, but needs to be significantly refactored. 1. there are various debugging statements 2. huge bytecode without source or comment 3. should probably live in a `beforeAll` so it can be re-used * test(cli/governance:propose): refactors multisig creation Now in a `beforeAll` and bytecode in `constants.ts` * test(cli/governance:propose): refactors multisig creation into a function * test(cli/governance:propose): adds test for multisig with 2 signers * test(cli/governance:propose): remove `TODO` comments * feat(cli/governance:propose): adds descriptive error message The error messages are more descriptive, when the `--for` or `--usemultisig` flags are not set correctly. * chore(cli): adds changeset for cli change * chore(contractkit): adds changeset for drive-by contractkit change * chore(cli/governance:propose): removes TODO comment * chore(cli/governance:propose): improves `--for` flag error message * chore(cli/test-utils): replaces `parseInt` with `BigInt` `parseInt` converts to a number, which is not really safe when dealing with the large numbers we have on the EVM. Instead converting to a `BigInt` ensures better number handling. * chore(cli): adds `--force-exit` command to CLI test Aaron suggested this as a "hacky" way to prevent the CLI test run to fail on CI. The error we're trying to prevent is: ```sh Jest did not exit one second after the test run has completed. 'This usually means that there are asynchronous operations that weren't stopped in your tests. Consider running Jest with `--detectOpenHandles` to troubleshoot this issue. ``` * test(cli/governance:propose): removes `beforeAll` to fix snapshot error `beforeAll` interfered with `snapId` as defined in `testWithGanache`. As a short-term fix, we agreed to remove `beforeAll` and create multisigs on-demand in the specific `test()`. When we migrate from Ganache to Anvil, we might consider adding better support for `beforeAll` without interfering with snapshots. commit 34c654e769403f0b049dd59498bbf2f1de897e61 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed May 8 15:06:04 2024 +0200 chore(deps): update dependency jinja2 to v3.1.4 [security] (#234) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 7b93642803261b37971dd3c07f8748b6bc8f3378 Author: Leszek Stachowski <[email protected]> Date: Wed May 8 14:34:26 2024 +0200 isCel2 util (#235) commit e7ac487358c30593cfef0497a7e67325a893ac14 Author: Aaron DeRuvo <[email protected]> Date: Fri Apr 19 15:11:08 2024 +0200 deprecate cip8 commands for offchain storage. (#231) * deprecate cip8 commands for offchain storage. Co-authored-by: Arthur Gousset <[email protected]> --------- Co-authored-by: Arthur Gousset <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for CEL2
FeeCurrencyDirectorycontract.Based on
isCel2check from@celo/connectit will either fallback toFeeCurrencyWhitelistor use the new one.Other changes
None.
Tested
Manually published
@celo/abispackage withFeeCurrencyDirectoryto be able to introduce a wrapper for the new contract.Backwards compatibility
It's backwards compatible. The new contract now shares a portion of the code with the old one, but the interface didn't change.
TODO
PR-Codex overview
This PR adds support for the FeeCurrencyDirectory contract, updates timeout values, and enhances fee currency handling in the Celo SDK and CLI.
Detailed summary