-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs ci: manually copy the files rather than use the postinstall hook #214
Conversation
|
1d510f7
to
2ef46bc
Compare
Fixes celo-org/docs#1254 |
@@ -2,6 +2,6 @@ | |||
|
|||
// eslint-disable-next-line unicorn/prefer-top-level-await | |||
;(async () => { | |||
const oclif = await import('@oclif/core') | |||
const oclif = require('@oclif/core') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolasbrugneaux i know you said this works. just checking that you completely cleaned before rebuilding re packing etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did but for the sake of the argument, redoing it. Plus the tests are finishing the ci by yarn workspace @celo/celocli run celocli account:new
which uses this entrypoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change though at all?
This PR has the following fixes:
cp
command rather than the postinstall hook of the target repository (docs) because it includes more logic (such asgit submodules update
which defeated the docs gh action)await import
but good ol'require
so oclif can generate the docs