Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs ci: manually copy the files rather than use the postinstall hook #214

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

nicolasbrugneaux
Copy link
Contributor

@nicolasbrugneaux nicolasbrugneaux commented Apr 2, 2024

This PR has the following fixes:

  • [CI] uses a cp command rather than the postinstall hook of the target repository (docs) because it includes more logic (such as git submodules update which defeated the docs gh action)
  • [CLI docs] fixes the entrypoint to not use await import but good ol' require so oclif can generate the docs

@nicolasbrugneaux nicolasbrugneaux requested a review from a team as a code owner April 2, 2024 14:59
Copy link

changeset-bot bot commented Apr 2, 2024

⚠️ No Changeset found

Latest commit: 42bca8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nicolasbrugneaux
Copy link
Contributor Author

Fixes celo-org/docs#1254

@nicolasbrugneaux nicolasbrugneaux self-assigned this Apr 4, 2024
@@ -2,6 +2,6 @@

// eslint-disable-next-line unicorn/prefer-top-level-await
;(async () => {
const oclif = await import('@oclif/core')
const oclif = require('@oclif/core')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolasbrugneaux i know you said this works. just checking that you completely cleaned before rebuilding re packing etc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did but for the sake of the argument, redoing it. Plus the tests are finishing the ci by yarn workspace @celo/celocli run celocli account:new which uses this entrypoint

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change though at all?

@nicolasbrugneaux nicolasbrugneaux merged commit 61c43e2 into master Apr 4, 2024
19 checks passed
@nicolasbrugneaux nicolasbrugneaux deleted the fix/docs-workflow branch April 4, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants