Automatically register account if needed when locking #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… account. Given that account is often used a synonym for eoa it was not clear from error messages that one must run account:register. this was it happens automatically
🦋 Changeset detectedLatest commit: 82ea521 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
shazarre
approved these changes
Mar 29, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than failing of EOA is not registered with Account contract, just do the registration
simplify the process of voting by registering eoa as given that account is often used a synonym for eoa it was not clear from error messages that one must run account:register. this way it happens automatically for a nicer ux
This is slightly different than plan specified in #142 which was to register and lock while voting. but i think now that locking and voting in same might be a bit much
Other changes
n/a
Tested
add new test
Related issues
Backwards compatibility
yes
Documentation
n/a