-
Notifications
You must be signed in to change notification settings - Fork 12
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cleanup old functions from base (#228)
### Description these have been either marked deprecated for ages and or are just completely out of scope for the type of functions we should be supporting. ### Other changes nope. ### Tested seem unused internally ### Related issues ### Backwards compatibility nope / removing things ### Documentation <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on removing deprecated functions and constants from various modules in the `sdk` package, specifically related to `contacts`, `displayFormatting`, `currencies`, and `phoneNumbers`. It also introduces new claim types and metadata handling in the `metadata-claims` module. ### Detailed summary - Removed deprecated functions and constants from: - `contacts` - `displayFormatting` - `currencies` - `phoneNumbers` - Introduced new claim types in `metadata-claims`: - `AccountClaimType` - `KeybaseClaimType` - `DomainClaimType` - `NameClaimType` - `StorageClaimType` - Enhanced `IdentityMetadataWrapper` for improved metadata handling. - Updated documentation to reflect removed exports and new structures. > The following files were skipped due to too many changes: `packages/sdk/metadata-claims/lib/metadata.js` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
- Loading branch information
Showing
55 changed files
with
893 additions
and
1,021 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
--- | ||
'@celo/base': major | ||
'@celo/utils': major | ||
--- | ||
|
||
remove deprecated functions and consts exported from ./contacts and ./displayformating. ./currencies and ./phonenumbers. If these are used by your app we recommend to inline the functions from the previous release. | ||
|
||
* https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/contacts.ts | ||
* https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/displayFormatting.ts | ||
* https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/phoneNumbers.ts | ||
|
||
https://github.com/celo-org/developer-tooling/tree/%40celo/wallet-base%406.0.1/packages/sdk/base/src | ||
|
||
Full List of removed exports -- ContactPhoneNumber, MinimalContact, getContactPhoneNumber, isContact, CURRENCY_ENUM, Currency, CURRENCIES, resolveCurrency, SHORT_CURRENCIES, currencyToShortMap | getErrorMessage | anonymizedPhone | getContactNameHash | ||
|
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.