Skip to content

Commit

Permalink
and we have a pass
Browse files Browse the repository at this point in the history
  • Loading branch information
aaronmgdr committed Mar 21, 2024
1 parent c9e1547 commit 1e6996d
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 26 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -92,3 +92,4 @@ package.json-e
# Ignore generated credentials from google-github-actions/auth
gha-creds-*.json
transactions.json
transactions2.json
1 change: 1 addition & 0 deletions packages/cli/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ oclif.manifest.json
src/generated
.devchain/
.devchain.tar.gz
transactions2.json
32 changes: 9 additions & 23 deletions packages/cli/src/commands/governance/propose.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Address } from '@celo/connect'
import { StrongAddress } from '@celo/base'
import { newKitFromWeb3 } from '@celo/contractkit'
import { GoldTokenWrapper } from '@celo/contractkit/lib/wrappers/GoldTokenWrapper'
import { GovernanceWrapper } from '@celo/contractkit/lib/wrappers/Governance'
Expand Down Expand Up @@ -144,10 +144,10 @@ testWithGanache('governance:propose cmd', (web3: Web3) => {
const minDeposit = web3.utils.toWei(expConfig.minDeposit.toString(), 'ether')
const kit = newKitFromWeb3(web3)

let accounts: Address[] = []
let accounts: StrongAddress[] = []

beforeEach(async () => {
accounts = await web3.eth.getAccounts()
accounts = (await web3.eth.getAccounts()) as StrongAddress[]
kit.defaultAccount = accounts[0]
governance = await kit.contracts.getGovernance()
goldToken = await kit.contracts.getGoldToken()
Expand Down Expand Up @@ -360,25 +360,11 @@ testWithGanache('governance:propose cmd', (web3: Web3) => {

const transactionsForContractsVerifiedOnCeloScan = [
{
contract: '0xFa3df877F98ac5ecd87456a7AcCaa948462412f0',
address: '0xFa3df877F98ac5ecd87456a7AcCaa948462412f0',
function: 'removeLiquidity(uint256,uint256[],uint256)',
args: ['10000000000000000000000000', ['0', '0'], 1674883684],
value: '0',
},
{
contract: '0x765de816845861e75a25fca122bb6898b8b1282a',
address: '0x765de816845861e75a25fca122bb6898b8b1282a',
function: 'approve(address,uint256)',
args: ['0x87647780180B8f55980C7D3fFeFe08a9B29e9aE1', '11000000000000000000000000'],
value: '0',
},
{
contract: '0x37f750B7cC259A2f741AF45294f6a16572CF5cAd',
address: '0x37f750B7cC259A2f741AF45294f6a16572CF5cAd',
function: 'approve(address,uint256)',
args: ['0x87647780180B8f55980C7D3fFeFe08a9B29e9aE1', '11000000000000'],
value: '0',
contract: 'Vyper_contract',
address: '0xf4cab10dC19695AaCe14b7A16d7705b600ad5F73',
function: 'transfer(address,uint256)',
args: ['0x87647780180B8f55980C7D3fFeFe08a9B29e9aE1', '20001239154911011864219072'],
value: 0,
},
]

Expand All @@ -402,7 +388,7 @@ testWithGanache('governance:propose cmd', (web3: Web3) => {
'--deposit',
'1000000000000000000',
'--from',
accounts[0],
accounts[0] as StrongAddress,
'--descriptionURL',
'https://example.com',
])
Expand Down
3 changes: 2 additions & 1 deletion packages/cli/src/commands/governance/propose.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { StrongAddress } from '@celo/base'
import { ProposalBuilder, proposalToJSON, ProposalTransactionJSON } from '@celo/governance'
import { Flags } from '@oclif/core'
import { BigNumber } from 'bignumber.js'
Expand Down Expand Up @@ -52,7 +53,7 @@ export default class Propose extends BaseCommand {
const res = await this.parse(Propose)
const account = res.flags.from
const deposit = new BigNumber(res.flags.deposit)
kit.defaultAccount = account
kit.defaultAccount = account as StrongAddress

await newCheckBuilder(this, account)
.hasEnoughCelo(account, deposit)
Expand Down
1 change: 0 additions & 1 deletion packages/cli/transactions2.json

This file was deleted.

1 change: 0 additions & 1 deletion packages/sdk/explorer/src/block-explorer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,6 @@ export class BlockExplorer {
)
}
const mapping = metadata?.toContractMapping()
console.info('CS map', address)
mapping?.fnMapping.forEach((selector) => {
console.info(selector.name, JSON.stringify(selector))
})
Expand Down

0 comments on commit 1e6996d

Please sign in to comment.