-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Fingerprint Configuration #264
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
13147284 | Triggered | Generic High Entropy Secret | 89a89ea | test/app.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@types/[email protected], npm/[email protected], npm/[email protected] |
Description
I can't take it anymore. We need to do a full release cycle every time we an SSL Fingerprint changes, and on top of that we've moved away from using leaf SSL fingerprints to do this less often, thus being less secure in practice.
This PR adds the long awaited dynamic configuration of SSL certificates from a global source of truth, and what better source of truth than a blockchain! So first head over to the new Oracle SSL Fingerprint Registry.
The implementation is quite simple, there as a new service (SSLFingerprintService) that reads all fingerprints from the chain, keeps them in mapping and subscribes to update events in order to update the mapping. The service is passed into the DataAggregator and ultimately each ExchangeAdaptor, there it's used to get the fingerprint in lieu of the static attribute.
Failure modes:
Other changes
N/A
Tested
Related issues
90% of on-call requests.
Backwards compatibility
Nope.