Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Docker build failing #230

Merged
merged 4 commits into from
Mar 18, 2024
Merged

fix: Docker build failing #230

merged 4 commits into from
Mar 18, 2024

Conversation

bowd
Copy link
Collaborator

@bowd bowd commented Mar 15, 2024

Description

I've been trying to cut a new release but Docker build is failing: https://github.com/celo-org/celo-oracle/actions/runs/8288144515
The problems seams to be the one described here: https://mtsknn.fi/blog/yarn-install-failing/
Long term we should update our deps including yarn – potentially switching from yarn to pnpm – which I tried first and made some progress there in #227. But this PR updates the node version to 20.11 which also seams to fix the problem.

Other changes

  • Removed a Dockerfile that didn't look like it was used.
  • Updated node version in CI

Tested

Ran locally with node 20.11 and created docker image and ran it.

Related issues

  • On call incident

Backwards compatibility

N/A

@bowd bowd merged commit a05fe70 into main Mar 18, 2024
7 checks passed
@bowd bowd deleted the fix/docker-build branch March 18, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants