Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: sunset "Overview" and "Mento" tabs #1009

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

shazarre
Copy link

@shazarre shazarre commented Dec 19, 2023

Description

This PR sunsets "Overview" and "Mento" statistic tabs providing an alternative.

Other changes

Refactored how stat pages are handled. Every page is a separate route now and it has been split into 2 ways of displaying the pages:

  • notifications: providing an alternative
  • iframe: providing stats in a form of an iframe how it used to be

Tested

Tested locally.

Screenshot 2023-12-19 at 14 21 01

Screenshot 2023-12-19 at 14 21 42

Copy link

github-actions bot commented Dec 19, 2023

Unit Test Results

       5 files  ±0     363 suites  ±0   3m 33s ⏱️ -2s
2 637 tests ±0  2 563 ✔️ ±0  74 💤 ±0  0 ±0 
2 651 runs  ±0  2 575 ✔️ ±0  76 💤 ±0  0 ±0 

Results for commit ed5354f. ± Comparison against base commit 5c60644.

♻️ This comment has been updated with latest results.

@shazarre shazarre marked this pull request as ready for review December 20, 2023 09:27
@shazarre shazarre requested a review from a team as a code owner December 20, 2023 09:27
@shazarre shazarre requested a review from alvarof2 December 20, 2023 09:27
@shazarre shazarre self-assigned this Dec 20, 2023
@shazarre shazarre merged commit 1cb34d7 into master Dec 20, 2023
27 checks passed
@shazarre shazarre deleted the shazarre/Stats_sunset_Overview_and_Mento_tabs branch December 20, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants