fix: rpc "no port provided" error by backporting #1528
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
requested review from
cmwaters and
ninabarbakadze
and removed request for
a team
rootulp
reviewed
Nov 15, 2024
| @@ -24,7 +25,7 @@ const ( | |||
| protoUNIX = "unix" | |||
| ) | |||
|
|
|||
| //------------------------------------------------------------- | |||
| var endsWithPortPattern = regexp.MustCompile(`:[0-9]+$`) | |||
There was a problem hiding this comment.
golangci-lint complains here
rootulp
previously approved these changes
Nov 15, 2024
rach-id
previously approved these changes
Nov 15, 2024
|
marked as a draft for a sec while I debug some simple but annoying IPv6 address handling. works locally, but fails here |
|
What's the actual problem here? Is it when you specify a rpc address as http://localhost:26657 as opposed to just localhost:26657 it doesn't work (because of the double colon) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixing this insanely annoying error so we can actually use rpcs