chore!: make the row proof range end exclusive

[rach-id]

Description

Closes #1375

It would be nice if we could cram this change also in v2. If not, then once this change makes it to a release, we need to remember to update the app implementation and any downstream repo to use end exclusive ranges for row proofs. Would creating an issue work?

---

PR checklist

• Tests written/updated
• Changelog entry added in .changelog (we use
  unclog to manage our changelog)
• Updated relevant documentation (docs/ or spec/) and code comments

[cmwaters]

This is a breaking change right? I'm not sure if we've agreed on branch management / releases for celestia-core yet

[rach-id]

yes, it's a breaking change

[rootulp]

IMO we need a strategy on how to release breaking changes of celestia-core before we merge this

[rach-id]

[thinking out loud]
Why not have a v0.34.x-v2 branch that contains the breaking changes. This branch should only contain the changes that are on main and we want to include in v2.
The existing branch v0.34.x could be renamed to v0.34.x-v1 to reflect that this is the verison used for V1.

[cmwaters]

[thinking out loud] Why not have a v0.34.x-v2 branch that contains the breaking changes. This branch should only contain the changes that are on main and we want to include in v2. The existing branch v0.34.x could be renamed to v0.34.x-v1 to reflect that this is the verison used for V1.

The problem is a little more complex then that given our current upgrading strategy. We could be running v2 binary on a v1 network, thus celestia-core also needs to be wary of the app version

[rootulp]

Why not have a v0.34.x-v2 branch that contains the breaking changes.

celestia-app v2 won't use any celestia-core breaking changes that aren't present in celestia-core v1.36.1-tm-v0.34.29 because celestia-app v2.0.0-rc1 is being audited and it depends on v1.36.1-tm-v0.34.29.

[evan-forbes]

are these proofs moved elsewhere for node @rach-id ? if so, can we close this and remove them here?

[rach-id]

Once we release the proofs in node. I will start deprecating the endpoints. But for the proofs implementation, it will remain in core because it's used in tx proof. So we still need this PR to be part of v3 if possible.