Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable optical stepping loop #1546

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Dec 11, 2024

This activates (and fixes) the optical stepping loop by updating the track status at the beginning of the step. We don't need an "initialize vacancies" action like with the main stepping loop because we won't manage secondaries the same way (see #1538 (comment) ). Instead, the "initialize track" action will reset the status to "initializing" for any new tracks, and the "pre-step" action will set the status to "inactive" for any tracks that died in the previous iteration but weren't replaced with newly generated photons.

With this change we're actually stepping photons outside of the geometry! (With no physics or interactions.)

@sethrj sethrj added enhancement New feature or request physics Particles, processes, and stepping algorithms labels Dec 11, 2024
Copy link

Test summary

 3 901 files   6 012 suites   4m 15s ⏱️
 1 618 tests  1 589 ✅ 29 💤 0 ❌
20 006 runs  19 931 ✅ 75 💤 0 ❌

Results for commit 4292320.

@sethrj sethrj merged commit 6338b6c into celeritas-project:develop Dec 11, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request physics Particles, processes, and stepping algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants