Add along-step and tracking cut optical executors #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
enhancement
Test summary 3 884 files 5 995 suites 4m 14s ⏱️ Results for commit ae25f53. ♻️ This comment has been updated with latest results. |
amandalund
approved these changes
Dec 7, 2024
|
Sorry it took so long! I've gotta fix the cuda build and will test it too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds along-step (distance-to-boundary + move + time update) and tracking cut (currently not used, but kills the tracks) to the optical tracking loop.
I fixed an overzealous assertion in the Cherenkov generator: it's allowable not to have any photons generated over a step.