Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add piecewise integrator and CDF utilities #1537

Merged
merged 7 commits into from
Dec 6, 2024
Merged

Add piecewise integrator and CDF utilities #1537

merged 7 commits into from
Dec 6, 2024

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Dec 6, 2024

  • Add integrator for piecewise linear and constant CDFs
  • Update Cherenkov and WLS params to use it
  • Use MaterialView in Cherenkov params construction
  • Flip CDF/energy axes in WLS to be standard

@sethrj sethrj added physics Particles, processes, and stepping algorithms minor Minor internal changes or fixes labels Dec 6, 2024
@sethrj sethrj requested review from amandalund and whokion December 6, 2024 14:57
@sethrj sethrj mentioned this pull request Dec 6, 2024
Open
10 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

Test summary

 3 884 files   5 995 suites   4m 13s ⏱️
 1 613 tests  1 584 ✅ 29 💤 0 ❌
19 948 runs  19 873 ✅ 75 💤 0 ❌

Results for commit 5444518.

♻️ This comment has been updated with latest results.

amandalund
amandalund approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@amandalund amandalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/celeritas/grid/GenericCalculator.hh Outdated Show resolved Hide resolved
src/celeritas/optical/CherenkovParams.cc Outdated Show resolved Hide resolved
@sethrj sethrj merged commit 9ddda63 into celeritas-project:develop Dec 6, 2024
35 checks passed
@sethrj sethrj deleted the trapezoid-sum branch December 6, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandalund amandalund amandalund approved these changes

@whokion whokion Awaiting requested review from whokion

Assignees
No one assigned
Labels
minor Minor internal changes or fixes physics Particles, processes, and stepping algorithms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sethrj @amandalund