Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hepmc3/macro initialization in celer-g4 #1535

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Dec 5, 2024

@wdconinc encountered a few issues recently when trying to run celer-g4 from scratch.

  • Mark .mac file setup as deprecated since we're trying to transition celer-g4 to JSON-only input
  • Default secondary stack factor to 2; we're not enabling atomic relaxation by default we only need room for annihilation
  • Wrap HepMC3 construction in exception conversion to catch errors while loading
  • No longer set num_events since we're using the single-event model

@sethrj sethrj added bug Something isn't working app Application front ends labels Dec 5, 2024
@sethrj sethrj requested a review from amandalund December 5, 2024 13:33
Copy link
Contributor

@amandalund amandalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

Copy link

github-actions bot commented Dec 5, 2024

Test summary

 3 882 files   5 991 suites   4m 14s ⏱️
 1 609 tests  1 580 ✅ 29 💤 0 ❌
19 907 runs  19 832 ✅ 75 💤 0 ❌

Results for commit aa0a6f7.

@sethrj sethrj merged commit cbf14de into celeritas-project:develop Dec 5, 2024
35 checks passed
@sethrj sethrj deleted the wouter-bugs branch December 5, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Application front ends bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants