Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add muon pair production #1518

Merged
merged 14 commits into from
Dec 4, 2024

Conversation

amandalund
Copy link
Contributor

This adds the energy distribution, interactor, model, process, and tests for electron-positron pair production by muons.

@amandalund amandalund added enhancement New feature or request physics Particles, processes, and stepping algorithms labels Nov 24, 2024
Copy link

github-actions bot commented Nov 24, 2024

Test summary

 3 866 files   5 975 suites   4m 12s ⏱️
 1 605 tests  1 576 ✅ 29 💤 0 ❌
19 858 runs  19 783 ✅ 75 💤 0 ❌

Results for commit f586269.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@whokion whokion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amandalund Excellent! Just for your information, there is Geant4 TestEm17 example (under extended/electromagnetic) which tests different models of muon processes and can be used for PR verification plots with respect to Geant4 later - of course, our physics validate suite can be used for the model test. Additional observables that can be added are the scattered (post) muon energy (or energy loss) and the angular deviation, which essentially carry equivalent kinematical information for the final state (i.e., distributions of secondaries). Anyway, very nice work!

doc/implementation/em-physics.rst Outdated Show resolved Hide resolved
src/celeritas/em/model/MuPairProductionModel.hh Outdated Show resolved Hide resolved
src/celeritas/em/interactor/MuPairProductionInteractor.hh Outdated Show resolved Hide resolved
@amandalund
Copy link
Contributor Author

Thanks for pointing me to the TestEm17 example @whokion: we still need to validate all of these muon models, and it looks like this will be helpful.

Copy link
Member

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few uses of linterp perhaps, and some documentation updates?

test/celeritas/data/four-steel-slabs.root Outdated Show resolved Hide resolved
src/celeritas/ext/detail/GeantProcessImporter.cc Outdated Show resolved Hide resolved
src/celeritas/ext/detail/GeantProcessImporter.cc Outdated Show resolved Hide resolved
src/celeritas/em/distribution/MuPPEnergyDistribution.hh Outdated Show resolved Hide resolved
src/celeritas/em/distribution/MuPPEnergyDistribution.hh Outdated Show resolved Hide resolved
src/celeritas/em/interactor/MuPairProductionInteractor.hh Outdated Show resolved Hide resolved
src/celeritas/em/model/MuPairProductionModel.cc Outdated Show resolved Hide resolved
src/celeritas/em/model/MuPairProductionModel.cc Outdated Show resolved Hide resolved
@amandalund
Copy link
Contributor Author

Thanks for the feedback @sethrj! I think I've addressed everything now.

@sethrj
Copy link
Member

sethrj commented Dec 2, 2024

@amandalund I think if you merge upstream and re-export the data, we should now have a less preposterous MuPPET size.

Copy link
Member

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@sethrj
Copy link
Member

sethrj commented Dec 3, 2024

@amandalund Feel free to merge if you're not waiting on @stognini for feedback.

@stognini
Copy link
Member

stognini commented Dec 3, 2024

Sorry for going slowly through the PR, but it looks pretty good to me.

@amandalund
Copy link
Contributor Author

No prob @stognini, I'll wait until you're through.

Copy link
Member

@stognini stognini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks @amandalund !

@amandalund amandalund enabled auto-merge (squash) December 4, 2024 17:01
@amandalund amandalund merged commit a043978 into celeritas-project:develop Dec 4, 2024
33 checks passed
@amandalund amandalund deleted the muon-pair-production branch December 4, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request physics Particles, processes, and stepping algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants