-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add muon pair production #1518
Add muon pair production #1518
Conversation
Test summary 3 866 files 5 975 suites 4m 12s ⏱️ Results for commit f586269. ♻️ This comment has been updated with latest results. |
abc8c00
to
14a13af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amandalund Excellent! Just for your information, there is Geant4 TestEm17 example (under extended/electromagnetic) which tests different models of muon processes and can be used for PR verification plots with respect to Geant4 later - of course, our physics validate suite can be used for the model test. Additional observables that can be added are the scattered (post) muon energy (or energy loss) and the angular deviation, which essentially carry equivalent kinematical information for the final state (i.e., distributions of secondaries). Anyway, very nice work!
Thanks for pointing me to the TestEm17 example @whokion: we still need to validate all of these muon models, and it looks like this will be helpful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few uses of linterp perhaps, and some documentation updates?
Thanks for the feedback @sethrj! I think I've addressed everything now. |
@amandalund I think if you merge upstream and re-export the data, we should now have a less preposterous MuPPET size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
@amandalund Feel free to merge if you're not waiting on @stognini for feedback. |
Sorry for going slowly through the PR, but it looks pretty good to me. |
No prob @stognini, I'll wait until you're through. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. Thanks @amandalund !
This adds the energy distribution, interactor, model, process, and tests for electron-positron pair production by muons.