Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows test builds #1255

Merged
merged 5 commits into from
May 30, 2024
Merged

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented May 28, 2024

This activates the build for googletest on windows so that we can guarantee compatibility on windows systems.

Differences from looking at test failures:

  • hashing std::variant does not account for the "type" of the object, so two integer variants will compare the same even if they're different types
  • the urban energy loss fluctuation model produces slightly different (but statistically equivalent) results

@sethrj sethrj added bug Something isn't working core Software engineering infrastructure labels May 28, 2024
@sethrj sethrj force-pushed the windows-test-fix branch 3 times, most recently from 6302c1e to d6d9e00 Compare May 28, 2024 19:59
@sethrj sethrj force-pushed the windows-test-fix branch from 0659205 to eb7585a Compare May 29, 2024 12:46
@sethrj sethrj force-pushed the windows-test-fix branch from eb7585a to bf36f27 Compare May 29, 2024 19:04
@sethrj sethrj requested a review from pcanal May 29, 2024 19:04
@sethrj sethrj marked this pull request as ready for review May 29, 2024 19:04
@sethrj sethrj enabled auto-merge (squash) May 30, 2024 20:05
@sethrj sethrj merged commit 3bf3bed into celeritas-project:develop May 30, 2024
28 of 29 checks passed
@sethrj sethrj deleted the windows-test-fix branch August 1, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Software engineering infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants