Require JSON #1254
Merged
Require JSON #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
core
sethrj
force-pushed
the
require-json
branch
2 times, most recently
from
f516168 to
7af7ba0
Compare
|
I think requiring |
drbenmorgan
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #1253 : we're using JSON increasingly and will require it for the python front end (https://github.com/celeritas-project/celerpy/) and now have the ability to automatically provide it if it's not on the system. Requiring JSON simplifies a lot of the code, and other packages in the typical HEP pipeline (viz., ROOT) require nlohmann-json.
The only downside I see is the increased chance of causing a conflict in a multi-library toolchain (in which case nljson is hopefully already found, since e.g. ROOT is loaded before the initial decision to use JSON as an external?) or for G4VG where JSON isn't ever used in practice but this would require it.