Feat/api blob proofs #312
Merged
Feat/api blob proofs #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aopoltorzhicky
requested changes
Nov 30, 2024
cmd/api/handler/responses/ods.go
Outdated
|
|
||
| const ( | ||
| // ShareVersionZero is the first share version format. | ||
| ShareVersionZero = uint8(0) |
There was a problem hiding this comment.
можешь импортировать эти константы из кора
cmd/api/handler/responses/ods.go
Outdated
| nsStartIdx := int(startRow*edsWidth + startCol) | ||
|
|
||
| for shareIdx, s := range shares { | ||
| if !bytes.Contains(SupportedShareVersions, []byte{s.Version()}) { |
There was a problem hiding this comment.
Для простоты понимания можно написать просто s.Version() <= 1, потому что только 2 версии доступно пока
pkg/node/rpc/blob.go
Outdated
|
|
||
| func (api *API) BlobProofs(ctx context.Context, level pkgTypes.Level, startShare, endShare int) (pkgTypes.BlobProof, error) { | ||
| args := make(map[string]string) | ||
| if level != 0 { |
There was a problem hiding this comment.
По идее все параметры запроса у тебя обязательные, поэтому можешь кидать ошибку, если хоть кто-то из них меньше 0, а level должен быть больше 0
aopoltorzhicky
requested changes
Dec 3, 2024
cmd/api/handler/namespace.go
Outdated
| return internalServerError(c, err) | ||
| } | ||
|
|
||
| proofs, err := handler.node.BlobProofs(c.Request().Context(), req.Height, startBlobIdx, endBlobIdx) |
There was a problem hiding this comment.
Здесь может быть startBlobIdx == endBlobIdx == 0. По крайней мере у меня так получилось с первым попавшимся блобом. Из-=за этого нода пятистоит
k-karuna
force-pushed
the
feat/api-blob-proofs
branch
from
aea26bb to
492c4e4
Compare
…EDS from celestia-app
k-karuna
force-pushed
the
feat/api-blob-proofs
branch
from
09fe2ea to
3bc3c79
Compare
aopoltorzhicky
requested changes
Dec 5, 2024
pkg/node/api.go
Outdated
| @@ -20,6 +20,7 @@ type Api interface { | |||
| Genesis(ctx context.Context) (types.Genesis, error) | |||
| BlockData(ctx context.Context, level pkgTypes.Level) (pkgTypes.BlockData, error) | |||
| BlockDataGet(ctx context.Context, level pkgTypes.Level) (pkgTypes.BlockData, error) | |||
| BlobProofs(ctx context.Context, level pkgTypes.Level, startShare, endShare int) (pkgTypes.BlobProof, error) | |||
There was a problem hiding this comment.
По идее, это можно выпилить
aopoltorzhicky
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.