Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markerEnd in BiDirectionalEdge component (was not passed down cor… #65

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

idumitru-cds
Copy link
Collaborator

An initial attempt to fix the directional arrowhead issue. While the markerEnd is being passed down correctly now (to the custom Edge component), I'm still not happy how the arrow head aligns itself agains the edge line, particularly at very wide angles... Still happy to push this into main for now, as it's not a show stopper.

@idumitru-cds idumitru-cds linked an issue Mar 27, 2024 that may be closed by this pull request
@idumitru-cds
Copy link
Collaborator Author

Screenshot 2024-03-27 at 6 21 22 PM

Copy link

Copy link
Collaborator

@maxneuvians maxneuvians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@idumitru-cds idumitru-cds merged commit 0128e02 into main Mar 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directional Arrow Head needed
2 participants